Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge of str columns panics #5687

Open
fulmicoton opened this issue Feb 19, 2025 · 0 comments
Open

Merge of str columns panics #5687

fulmicoton opened this issue Feb 19, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@fulmicoton
Copy link
Collaborator

As experience on airmail, in some conditions, merging splits can fail with the following panic

usr/local/cargo/git/checkouts/tantivy-f70b7ea03dadae9a/71cf198/columnar/src/columnar/merge/merge_dict_column.rs:70:42:
Feb 18 09:57:32 quickwit-indexer-13 quickwit-indexer index out of bounds: the len is 1034 but the index is 1876
@fulmicoton fulmicoton added the bug Something isn't working label Feb 19, 2025
fulmicoton-dd added a commit that referenced this issue Feb 19, 2025
@fulmicoton-dd
Attempt to limit the impact of bug #5687.
020d00f 
With this commit, a failing merge will not restart the indexing pipeline.
This should prevent the split of death loop.
fulmicoton-dd added a commit that referenced this issue Feb 19, 2025
@fulmicoton-dd
Attempt to limit the impact of bug #5687.
819f25b 
With this commit, a failing merge will not restart the indexing pipeline.
This should prevent the split of death loop.
fulmicoton-dd added a commit that referenced this issue Feb 19, 2025
@fulmicoton-dd
Attempt to limit the impact of bug #5687.
9f3e803 
With this commit, a failing merge will not restart the indexing pipeline.
This should prevent the split of death loop.

This also include a tantivy fix, that adds a panic handler on the merge thread pool
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fulmicoton