Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning, Address Sanitizer #37

Merged
merged 5 commits into from
Jan 4, 2024
Merged

Warning, Address Sanitizer #37

merged 5 commits into from
Jan 4, 2024

Conversation

KowerKoint
Copy link
Contributor

No description provided.

@KowerKoint KowerKoint changed the base branch from main to 24-GPUenv January 4, 2024 07:57
@KowerKoint
Copy link
Contributor Author

WARNING_CPPがセットされてるのに使われていないのでWarningをセットし直しました。
Warningが厳しすぎてKokkosのビルドが通らないのでKokkosのビルドオプションに合わせました ( https://github.com/kokkos/kokkos/blob/master/cmake/kokkos_arch.cmake#L131 )

CMAKE_CXX_FLAGSを直接いじるのはよくないらしい ( https://qiita.com/shohirose/items/5b406f060cd5557814e9#cmake_lang_flags%E3%81%AB%E3%82%AA%E3%83%97%E3%82%B7%E3%83%A7%E3%83%B3%E3%82%92%E8%B6%B3%E3%81%95%E3%81%AA%E3%81%84 ) らしいのでtarget_compile_optionsを使いました

@KowerKoint
Copy link
Contributor Author

他のオプションもqulacsのPUBLICなtarget_compiile_optionsとして設定するようにしました。
また、CMAKE_BUILD_TYPEがDebugのときaddress sanitizerが走るようにしました。

@KowerKoint KowerKoint marked this pull request as ready for review January 4, 2024 08:27
@KowerKoint
Copy link
Contributor Author

close #23

@gandalfr-KY
Copy link
Contributor

変更箇所確認しました!ありがとうございます。

@KowerKoint KowerKoint merged commit cea4b57 into 24-GPUenv Jan 4, 2024
4 checks passed
@KowerKoint KowerKoint deleted the 23-sanitizer branch January 4, 2024 09:12
@KowerKoint KowerKoint mentioned this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants