Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg-config file is broken when CMAKE_INSTALL_{INCLUDE,LIB}DIR is absolute #551

Open
alexshpilkin opened this issue May 17, 2022 · 1 comment
Labels
bug/fix The library doesn't work as expected

Comments

@alexshpilkin
Copy link

Describe the bug

As per title: Quotient.pc.in has

prefix=@CMAKE_INSTALL_PREFIX@
exec_prefix=${prefix}
includedir=${prefix}/@CMAKE_INSTALL_INCLUDEDIR@
libdir=${prefix}/@CMAKE_INSTALL_LIBDIR@

and so can’t handle absolute paths in CMAKE_INSTALL_{INCLUDE,LIB}DIR. This leads to broken .pc files on NixOS in particular.

Additional context

See “Concatenating paths when building pkg-config files” for a thorough discussion of the problem and a suggested fix, or KDE’s extra-cmake-modules for a simpler approach.

Related to #447.

@alexshpilkin alexshpilkin added the bug/fix The library doesn't work as expected label May 17, 2022
@KitsuneRal
Copy link
Member

Thanks for the report. To be honest, I wasn't sure if we should still keep pkg-config files now that CMake is pretty much the only (tested) way to build and link against libQuotient. But I can understand why pkg-config can be easier to start with and make simpler applications.

@KitsuneRal KitsuneRal moved this to 0.9 - To Do in libQuotient 1 May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/fix The library doesn't work as expected
Projects
Status: 0.9 - To Do
Development

No branches or pull requests

2 participants