Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not more than 80 characters of line are parsed. #1

Open
amrein opened this issue Feb 4, 2014 · 5 comments
Open

Not more than 80 characters of line are parsed. #1

amrein opened this issue Feb 4, 2014 · 5 comments
Assignees

Comments

@amrein
Copy link

amrein commented Feb 4, 2014

Q parses only the first 80 characters of the fep-file-path (and crashes with non-sense error).

E.g. the following input will crash Q with no "atom-section found":
fep /path/to/wherever/i/store/my/genious/fepfile/because/it/stays/the/same/for/all/my/runs/fep.fep

Q tries the following "file" and is crashing with "[atom]"-section not found in fepfile:
/path/to/wherever/i/store/my/genious/fepfile/because/it/stays/the/same/for/all/

Workaround:
copy the file into local directory or use a soft-/hardlink ...

@ghost ghost assigned amrein Feb 4, 2014
@acmnpv
Copy link
Contributor

acmnpv commented Feb 4, 2014

Ok, this is something I also will need to look at.....
Fortran Error? Seems likely.

On 02/04/2014 09:36 AM, amrein wrote:

Q parses only the first 80 characters of the fep-file-path (and
crashes with non-sense error).

E.g. the following input will crash Q with no "atom-section found":
fep
/path/to/wherever/i/store/my/genious/fepfile/because/it/stays/the/same/for/all/my/runs/fep.fep

Q tries the following "file" and is crashing with "[atom]"-section not
found in fepfile:
/path/to/wherever/i/store/my/genious/fepfile/because/it/stays/the/same/for/all/

Workaround:
copy the file into local directory or use a soft-/hardlink ...


Reply to this email directly or view it on GitHub
#1.

@acmnpv
Copy link
Contributor

acmnpv commented Jan 5, 2015

I changed most of the character arrays now to a length of 200, is there a way to use dynamic array sizes (like in C++ strings) for characters?
Change is for now in my version of devel Q, will push later.

@esguerra
Copy link
Member

esguerra commented Jan 5, 2015

character(len=*)

@esguerra
Copy link
Member

esguerra commented Jan 5, 2015

or
character(len=:), allocatable :: variablename

@acmnpv
Copy link
Contributor

acmnpv commented Jan 5, 2015

Thanks, I will see that this gets changed globally ...

acmnpv pushed a commit that referenced this issue Jan 5, 2015
…changing some of the logic in the topology generation, please check that the new binary reproduces known topologies first.

Blame please towards me at [email protected]
Also some small first fix for the FEP file loading in qcalc to make sure iqatom is set to 0.
esguerra referenced this issue Nov 28, 2015
Various cleanup operations. Mainly restores.
Going back to the way ALL unix based programs
work, that is, by invoking one executable with
a simple name, e.g. charmm, sander, gmx, mdrun,
resp, xleap, no more qfep5 or even worst! UPPERCASE
Qfep5, as if it was a bad windows executable of
sorts. This is in line with the documentation.

Take a good look at the Fortran Best Practices:

http://www.fortran90.org/src/best-practices.html

Or at the gromacs coding rules:

http://jenkins.gromacs.org/job/Documentation_Nightly_master/javadoc/dev-manual/formatting.html

In principle, following a pep8 python style in
Fortran is useful. You are not coding alone!

Still tons of clean-up work is needed for
code readability and a developers manual is
a most. I am writing in LaTeX as it is easy to
maintain and could be eventually translated directly
to html or markdown if the need arises.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants