Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/trigger mapping overhaul #107

Merged
merged 30 commits into from
Oct 31, 2024
Merged

Conversation

THuckemann
Copy link
Collaborator

Implementing a couple of improvements for the device object, some bug fixes and changes to the trigger mapping.

THuckemann and others added 19 commits October 7, 2024 15:10
updates:
- [github.com/pre-commit/pre-commit-hooks: v4.6.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.6.0...v5.0.0)
- [github.com/asottile/pyupgrade: v3.17.0 → v3.19.0](asottile/pyupgrade@v3.17.0...v3.19.0)
- [github.com/psf/black: 24.8.0 → 24.10.0](psf/black@24.8.0...24.10.0)
@THuckemann THuckemann self-assigned this Oct 31, 2024
Copy link

github-actions bot commented Oct 31, 2024

Test Results

  4 files  ±0    4 suites  ±0   9s ⏱️ -3s
 25 tests ±0   25 ✅ ±0  0 💤 ±0  0 ❌ ±0 
100 runs  ±0  100 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 35a336c. ± Comparison against base commit f4e413a.

♻️ This comment has been updated with latest results.

This was linked to issues Oct 31, 2024
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 9.55882% with 123 lines in your changes missing coverage. Please review.

Project coverage is 22.35%. Comparing base (f4e413a) to head (35a336c).
Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
src/qumada/measurement/device_object.py 0.00% 84 Missing ⚠️
src/qumada/instrument/buffers/buffer.py 16.12% 26 Missing ⚠️
src/qumada/measurement/measurement.py 37.50% 10 Missing ⚠️
src/qumada/instrument/custom_drivers/ZI/MFLI.py 33.33% 2 Missing ⚠️
src/qumada/instrument/buffers/mfli_buffer.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
- Coverage   23.64%   22.35%   -1.29%     
==========================================
  Files          37       38       +1     
  Lines        4330     4620     +290     
==========================================
+ Hits         1024     1033       +9     
- Misses       3306     3587     +281     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@THuckemann THuckemann merged commit c49b60d into main Oct 31, 2024
7 checks passed
@THuckemann THuckemann deleted the feature/trigger_mapping_overhaul branch October 31, 2024 17:04
@THuckemann THuckemann linked an issue Jan 6, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add trigger setup to device mapping Add "enable_output" to mfli driver qcodes v0.40.0 breaks pytest
2 participants