From 161a953ce03e3a9c8fb0050ba8983524b62f4ade Mon Sep 17 00:00:00 2001
From: jack shelton <me@jackshelton.com>
Date: Fri, 30 Aug 2024 11:18:38 -0500
Subject: [PATCH 1/2] feat: add any markup inside the item label

---
 .../components/combobox/combobox-inline.tsx   | 28 ++++++++++++-------
 1 file changed, 18 insertions(+), 10 deletions(-)

diff --git a/packages/kit-headless/src/components/combobox/combobox-inline.tsx b/packages/kit-headless/src/components/combobox/combobox-inline.tsx
index ac8e604d4..89334daa7 100644
--- a/packages/kit-headless/src/components/combobox/combobox-inline.tsx
+++ b/packages/kit-headless/src/components/combobox/combobox-inline.tsx
@@ -45,6 +45,21 @@ export const HComboboxRoot: Component<InternalComboboxProps & HComboboxRootImplP
   const HComboboxItemLabel = UserItemLabel ?? InternalComboboxItemLabel;
   const HComboboxEmpty = InternalComboboxEmpty;
 
+  // recursively extracts the markup (ex: styling characters based on search)
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
+  function getInnerText(node: any): string {
+    if (typeof node === 'string') return node;
+    if (Array.isArray(node)) return node.map(getInnerText).join('');
+    if (node && typeof node === 'object') {
+      if ('props' in node && 'children' in node.props) {
+        return getInnerText(node.props.children);
+      } else if ('children' in node) {
+        return getInnerText(node.children);
+      }
+    }
+    return '';
+  }
+
   // source of truth
   const itemsMap = new Map();
   let currItemIndex = 0;
@@ -94,7 +109,9 @@ export const HComboboxRoot: Component<InternalComboboxProps & HComboboxRootImplP
       }
 
       case HComboboxItemLabel: {
-        const displayValue = child.props.children as string;
+        const displayValue = getInnerText(child.props.children);
+
+        console.log(displayValue);
 
         // distinct value, or the display value is the same as the value
         const value = (givenItemValue !== null ? givenItemValue : displayValue) as string;
@@ -114,15 +131,6 @@ export const HComboboxRoot: Component<InternalComboboxProps & HComboboxRootImplP
           _value = value;
         }
 
-        const isString = typeof child.props.children === 'string';
-
-        if (!isString) {
-          throw new Error(
-            `Qwik UI: select item label passed was not a string. It was a ${typeof child
-              .props.children}.`,
-          );
-        }
-
         // increment after processing children
         currItemIndex++;
 

From 7691b948ea8bce9ffe02ac15b32b9091660482d2 Mon Sep 17 00:00:00 2001
From: jack shelton <me@jackshelton.com>
Date: Fri, 30 Aug 2024 11:19:53 -0500
Subject: [PATCH 2/2] remove the log

---
 .../kit-headless/src/components/combobox/combobox-inline.tsx    | 2 --
 1 file changed, 2 deletions(-)

diff --git a/packages/kit-headless/src/components/combobox/combobox-inline.tsx b/packages/kit-headless/src/components/combobox/combobox-inline.tsx
index 89334daa7..b7e12a8e7 100644
--- a/packages/kit-headless/src/components/combobox/combobox-inline.tsx
+++ b/packages/kit-headless/src/components/combobox/combobox-inline.tsx
@@ -111,8 +111,6 @@ export const HComboboxRoot: Component<InternalComboboxProps & HComboboxRootImplP
       case HComboboxItemLabel: {
         const displayValue = getInnerText(child.props.children);
 
-        console.log(displayValue);
-
         // distinct value, or the display value is the same as the value
         const value = (givenItemValue !== null ? givenItemValue : displayValue) as string;