Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BP Nouveau compatibility #97

Open
6 tasks done
r-a-y opened this issue May 3, 2018 · 1 comment
Open
6 tasks done

BP Nouveau compatibility #97

r-a-y opened this issue May 3, 2018 · 1 comment

Comments

@r-a-y
Copy link
Owner

r-a-y commented May 3, 2018 •
edited
Loading

BP Nouveau is a new template pack that is scheduled to be released with BuddyPress 3.0.

Nouveau breaks the "Order By" dropdown filter when you are on a user's "Following" or "Followers" page. This is due in part because Nouveau looks for certain HTML elements that BP Legacy does not have.

Edit - discovered some other things. I'll be updating this list if I find more.

Issues:

  • Fix "Order By" AJAX dropdown filter
  • Use Nouveau's feedback function and remove initial member loop query
  • Fix button markup to use list-item instead of div container
  • Bring back follow counts in user navigation
  • Fix pagination on a user' "Followers" or "Following" page (commit 49a1c0d - requires BP 6.0.0)
  • Fix follow button onclick to use AJAX (commit 8f5d5f3)
r-a-y added a commit that referenced this issue May 3, 2018
@r-a-y
Nouveau: Fix the "Order By" AJAX dropdown filter.
26abbcb 
Nouveau looks for certain HTML data attributes to fire the AJAX request.
This commit adds these attributes.

See #97.
r-a-y added a commit that referenced this issue May 3, 2018
@r-a-y
Nouveau: Fix the "Order By" AJAX dropdown filter for v1.2.x.
babf893 
Backports commit 26abbcb for v1.2.x.

See #97.
r-a-y added a commit that referenced this issue May 3, 2018
@r-a-y
Nouveau: Alter 'members/single/follow' template to use feedback funct…
ed47e20 
…ion.

What this means is we don't have to query for the members loop when a user's
"Following" or "Followers" page is loaded.  The members loop is later added
via AJAX by Nouveau.

See #97.
r-a-y added a commit that referenced this issue May 3, 2018
@r-a-y
Nouveau: Alter 'members/single/follow' template to use feedback funct…
210e744 
…ion for v1.2.x.

Backports commit ed47e20 for v1.2-branch.

See #97.
@mrjarbenne
Copy link

Can the Follow button on the Blogs listing be added to the Issues check box. Adding the blog-button class seems to fix the layout, as seen in the second site in the screen shot:

2019-10-02_17-00-24

r-a-y added a commit that referenced this issue Jan 14, 2020
@r-a-y
Nouveau: Use correct button markup for blogs loop.
e357d08 
Nouveau expects a list-item and not a div container.

See #97.
r-a-y added a commit that referenced this issue Jan 14, 2020
@r-a-y
Nouveau: Use correct button markup for members loop.
991b111 
Nouveau expects a list-item and not a div container.

See #97.
r-a-y added a commit that referenced this issue Jan 14, 2020
@r-a-y
Nouveau: Fix follow count display in user navigation.
5c03169 
Nouveau only shows the count if the count is wrapped in a class called
"count".

See #97.

Fixes #109.
r-a-y added a commit that referenced this issue Apr 22, 2020
@r-a-y
Nouveau: Fix button AJAX functionality.
8f5d5f3 
See #97.
r-a-y added a commit that referenced this issue Apr 22, 2020
@r-a-y
Nouveau: Only override parent element if there is one to set.
fda1c62 
Nouveau is not consistent with their button elements. The template
pack uses multiple parent elements depending on the page.

See #97.
r-a-y added a commit that referenced this issue Apr 22, 2020
@r-a-y
Nouveau: Fix "Following" filter on the Member Directory page.
14aec28 
See #97.
r-a-y added a commit that referenced this issue Apr 22, 2020
@r-a-y
Nouveau: Fix pagination on a user's Following or Followers page.
49a1c0d 
Requires BuddyPress 6.0.0.

See #97.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrjarbenne @r-a-y