address DB2-related NOTEs (#844)

* re`document()` * address `cli_warn()` global variables NOTE * remove `@inheritParams` that brought in problematic \usage
r-dbi · Sep 5, 2024 · 5f51af7 · 5f51af7
1 parent b543d3b
commit 5f51af7
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 11 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -46,7 +46,7 @@ Config/Needs/website: tidyverse/tidytemplate
 Config/testthat/edition: 3
 Encoding: UTF-8
 Roxygen: list(markdown = TRUE)
-RoxygenNote: 7.3.0
+RoxygenNote: 7.3.2
 SystemRequirements: GNU make, An ODBC3 driver manager and drivers.
 Collate: 
     'RcppExports.R'

diff --git a/R/dbi-table.R b/R/dbi-table.R
@@ -180,7 +180,6 @@ setMethod("dbAppendTable", "OdbcConnection",
   })
 
 #' @rdname DBI-methods
-#' @inheritParams DBI::dbReadTable
 #' @export
 setMethod("sqlData", "OdbcConnection",
   function(con, value, row.names = NA, ...) {

diff --git a/R/driver-db2.R b/R/driver-db2.R
@@ -70,7 +70,7 @@ setMethod("odbcConnectionTables", c("DB2/AIX64", "character"),
         # NULL as colname is not well liked by DB2 it seems. Hack here.
         dfTempTables$table_remarks <- NA_character_
       }, odbc_database_error = function(e) {
-        cli_warn("Unable to query for temporary tables in SYSIBMADM.ADMINTEMPTABLES")
+        cli::cli_warn("Unable to query for temporary tables in SYSIBMADM.ADMINTEMPTABLES")
       })
     }
     rbind(res, dfTempTables)

diff --git a/man/DBI-methods.Rd b/man/DBI-methods.Rd
diff --git a/man/DBI-tables.Rd b/man/DBI-tables.Rd
diff --git a/man/odbc-package.Rd b/man/odbc-package.Rd