Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mocking for Databricks config tests #867

Closed
simonpcouch opened this issue Dec 9, 2024 · 0 comments · Fixed by #868
Closed

update mocking for Databricks config tests #867

simonpcouch opened this issue Dec 9, 2024 · 0 comments · Fixed by #868

Comments

@simonpcouch
Copy link
Collaborator

We missed this in #857, but there are a few local_mocked_bindings() that needed updating that are now showing failures on main:

══ Failed tests ════════════════════════════════════════════════════════════════
── Error ('test-driver-databricks.R:98:3'): dbConnect method handles httpPath aliases (#787) ──
Error in `local_mocked_bindings(databricks_args = function(...) stop("made it"), 
    configure_spark = function(...) TRUE)`: Can't find binding for `configure_spark`
Backtrace:
    ▆
 1. └─testthat::local_mocked_bindings(databricks_args = function(...) stop("made it"), configure_spark = function(...) TRUE) at test-driver-databricks.R:98:3
 2.   └─cli::cli_abort("Can't find binding for {.arg {missing}}")
 3.     └─rlang::abort(...)
── Error ('test-driver-databricks.R:108:3'): dbConnect method errors informatively re: httpPath (#787) ──
Error in `local_mocked_bindings(configure_spark = function(...) TRUE)`: Can't find binding for `configure_spark`
Backtrace:
    ▆
 1. └─testthat::local_mocked_bindings(configure_spark = function(...) TRUE) at test-driver-databricks.R:108:3
 2.   └─cli::cli_abort("Can't find binding for {.arg {missing}}")
 3.     └─rlang::abort(...)
── Error ('test-utils.R:157:3'): configure_simba() calls configure_unixodbc_simba() (#835) ──
Error in `local_mocked_bindings(locate_install_unixodbc = function() "hey", 
    locate_config_spark = function() "there", configure_unixodbc_simba = function(...) TRUE)`: Can't find binding for `locate_config_spark`
Backtrace:
    ▆
 1. └─testthat::local_mocked_bindings(...) at test-utils.R:157:3
 2.   └─cli::cli_abort("Can't find binding for {.arg {missing}}")
 3.     └─rlang::abort(...)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant