Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use git pull --rebase before attempting git push #86

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

Bisaloo
Copy link
Member

@Bisaloo Bisaloo commented Apr 28, 2024

Should address #53 (comment).

Discussed in https://epiforecasts.io/posts/2022-04-11-robust-actions/#git-repository-out-of-sync.

It took me a while to implement this as I was unsure about whether it could lead to out-of-sync snapshots in history. After staring at the code & GHA logs for a while today, I don't think it's an issue as the time in the csv file name is saved right after we do the CRAN snapshot.
If workflows take a while to get started, to install packages, etc., and snapshots are uploaded out of order, it shouldn't matter because the recorded time is still correct.

@Bisaloo Bisaloo merged commit 8347f81 into main May 3, 2024
5 checks passed
@Bisaloo Bisaloo deleted the git-pull-rebase branch May 3, 2024 07:31
@Bisaloo Bisaloo mentioned this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant