Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve WITec unit tests #75

Closed
4 tasks
Tracked by #42
GegznaV opened this issue Aug 10, 2021 · 2 comments · Fixed by #82
Closed
4 tasks
Tracked by #42

Improve WITec unit tests #75

GegznaV opened this issue Aug 10, 2021 · 2 comments · Fixed by #82
Assignees
@sangttruong
Labels
Topic: unit test 1️⃣
Milestone
1.0 CRAN submission

Comments

@GegznaV
Copy link
Member

GegznaV commented Aug 10, 2021 •
edited
Loading

In addition to current unit tests, add template #55 for these functions:

  • read_dat_WITec
  • read_txt_WITec
  • read_txt_WITec_Graph
  • read_txt_WITec_TrueMatch

(the current test should remain in the files)
@GegznaV GegznaV added this to the 1.0 CRAN submission milestone Aug 10, 2021
@GegznaV GegznaV mentioned this issue Aug 10, 2021
Closed
10 tasks
@GegznaV
Copy link
Member Author

GegznaV commented Aug 12, 2021

@sangttruong, can you do 4 separate PRs for this issue?

@GegznaV
Copy link
Member Author

GegznaV commented Aug 12, 2021

one for each file

@sangttruong sangttruong mentioned this issue Aug 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangttruong sangttruong

Labels
Topic: unit test 1️⃣
Projects
None yet
Milestone
1.0 CRAN submission
Development

Successfully merging a pull request may close this issue.

features/75-WITec-unittest r-hyperspec/hySpc.read.txt
2 participants
@GegznaV @sangttruong