-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/42 read zip renishaw #57
Conversation
…hyperspec/hySpc.read.txt into features/42-read-zip-Renishaw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add more unit tests
@@ -233,12 +233,11 @@ read_zip_Renishaw <- function(file = stop("filename is required"), | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sangttruong, please, apply/use template #55 for unit testing read_zip_Renishaw()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like comments and requested changes were addressed. Ready to merge.
Resolve #42