Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench::press() should be more generic #44

Open
jimhester opened this issue Apr 13, 2019 · 1 comment
Open

bench::press() should be more generic #44

jimhester opened this issue Apr 13, 2019 · 1 comment
Labels
feature a feature request or enhancement

Comments

@jimhester
Copy link
Member

E.g. you should be able to use it with system_time() or really anything that returns a data.frame

@jimhester jimhester added the feature a feature request or enhancement label Apr 3, 2020
@DavisVaughan
Copy link
Member

Consider that bench::press() currently tries to return a bench_mark() object at the end. We could generalize it a little by only wrapping in a bench_mark class if all of the individual results were bench_marks. Then each press expression could return any arbitrary data frame.

@DavisVaughan DavisVaughan changed the title bench::press should be more generic bench::press() should be more generic May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants