Merge pull request #660 from gvelasq/fix-vec-math-base

r-lib · Jun 24, 2024 · 4b06fb1 · 4b06fb1
2 parents 28b8219 + 784546d
commit 4b06fb1
Show file tree

Hide file tree

Showing 5 changed files with 48 additions and 46 deletions.
diff --git a/R/num.R b/R/num.R
@@ -127,7 +127,7 @@ vec_arith.numeric.pillar_num <- vec_arith.pillar_num.default
 vec_math.pillar_num <- function(.fn, .x, ...) {
   "!!!!DEBUG vec_math(`v(.fn)`)"
 
-  out <- vec_math_base(.fn, vec_proxy(.x))
+  out <- vec_math_base(.fn, vec_proxy(.x), ...)
 
   if (is.numeric(out)) {
     out <- vec_restore(out, .x)

diff --git a/tests/testthat/_snaps/ggplot2/log-scale.svg b/tests/testthat/_snaps/ggplot2/log-scale.svg
diff --git a/tests/testthat/_snaps/num.md b/tests/testthat/_snaps/num.md
@@ -467,6 +467,11 @@
     Output
       <pillar_num{%}*100[3]>
       [1] 84.1 90.9 14.1
+    Code
+      sum(num(c(1:3, NA)), na.rm = TRUE)
+    Output
+      <pillar_num[1]>
+      [1] 6
 
 # formatting
 

diff --git a/tests/testthat/test-ggplot2.R b/tests/testthat/test-ggplot2.R
@@ -19,7 +19,7 @@ test_that("ggplot2 snapshot tests", {
   log_scale <-
     ggplot2::ggplot(data, ggplot2::aes(x, z)) +
     ggplot2::geom_point() +
-    scale_y_num(trans = "log10") +
+    scale_y_num(transform = "log10") +
     ggplot2::theme_minimal(36)
 
   vdiffr::expect_doppelganger("log_scale", log_scale)

diff --git a/tests/testthat/test-num.R b/tests/testthat/test-num.R
@@ -170,6 +170,7 @@ test_that("mathematics", {
     min(num(1:3, label = "$"))
     mean(num(1:3, notation = "eng"))
     sin(num(1:3, label = "%", scale = 100))
+    sum(num(c(1:3, NA)), na.rm = TRUE)
   })
 })