Skip to content

Commit

Permalink
chore!: Hard-deprecate ellipsis for printing and formatting (#637)
Browse files Browse the repository at this point in the history
* Use error argument for check_dots_empty()

* Avoid passing dots

* Hard fail after check_dots_empty()

* revdep results

* Results

* Start with warning

* Slightly better

* Another try

* Good enough
  • Loading branch information
krlmlr authored Dec 15, 2024
1 parent e965800 commit a14fcb9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion R/tbl-format.R
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ format_tbl <- function(
max_footer_lines = NULL,
transform = identity
) {
check_dots_empty(action = signal)
check_dots_empty(error = function(cnd) warn("`...` must be empty in `format.tbl()`", parent = cnd))

if (!is.null(n_extra)) {
deprecate_stop("1.6.2", "pillar::format(n_extra = )", "pillar::format(max_extra_cols = )")
Expand Down

0 comments on commit a14fcb9

Please sign in to comment.