chore: drop scale_name ggplot2 arg and drop fansi dep
#663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… no need to depend on ggplot2 3.5.0) (no need to specify `scale_name`?
olivroy
changed the title
scale_name ggplot2 arg and use fansi::strip_ctl() instead of deprecated fansi::strip_sgr()scale_name ggplot2 arg and drop fansi dep
|
@krlmlr since cli provides a lot of the ansi functions, would you consider dropping fansi? or is the performance loss high? |
krlmlr
approved these changes
Jun 28, 2024
krlmlr
approved these changes
Jun 28, 2024
Co-authored-by: Kirill Müller <[email protected]>
|
I opened a PR in tibble and test them both! (tidyverse/tibble#1589) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop fansi dep and avoid setting scale_name in ggplot2