Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support printing of datetime without seconds #717

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Dec 16, 2024

It doesn't seem to work for now, but opening for discussion

Addresses #647

Seems to work, but the tests don't work.

image

@krlmlr
Copy link
Member

krlmlr commented Dec 16, 2024

Thanks. Is this a snapshot test that needs updating?

The "simple" shaft may work here, but should we perhaps use adaptive rendering (https://vctrs.r-lib.org/articles/pillar.html#adaptive-rendering) to support a larger variety of patterns?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants