Add cran parameter (#333 and #340 candidate fix) #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requesting review @gaborcsardi |
|
@gaborcsardi Is there any chance to address this in the nearest future? |
maksymiuks
changed the title
|
Added candidate fix for #340 |
|
Thanks and sorry for the super long wait! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gaborcsardi This is a candidate fix for #333
I've realized that fixing the issue reported above is dead simple. In my opinion
get_repos()helper should append CRAN to repos only conditionally on some input parameter, rather than every time CRAN is not found in current options. Therefore I've just added this parameter and propagated it upstream includingrevdep_check()and documentation.