Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scales: 2 issues #412

Closed
JJHelly opened this issue Nov 15, 2023 · 2 comments
Closed

scales: 2 issues #412

JJHelly opened this issue Nov 15, 2023 · 2 comments

Comments

@JJHelly
Copy link

JJHelly commented Nov 15, 2023

Aloha.
Just discovered scales and want to thank you for that. I find a couple of things to comment on.

  1. scale_x_continuous(labels = scales::label_number(accuracy = 0.5),
    breaks = c(-124, -120, -116))
    if accuracy = 0.0 (ie, integer) then the values on the axis are NA.

  2. It seems to me that 'accuracy' is more correctly 'precision'

Mahalo for the work.

@teunbrand
Copy link
Contributor

To round to integers you should use accuracy = 1, not accuracy = 0.
With regards to the accuracy/precision distinction, I don't really know what distinguishes these terms with regards to number formatting. However, I've seen 'precision' used to roughly mean 'the number of digits', which is not what the accuracy argument encodes.

@thomasp85
Copy link
Member

accuracy is correctly used here as it relates to how accurate the resulting label is to the true value. precision is more related to sampling and how good you are at repeating a measurement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants