Label composer #465
Merged
Label composer #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teunbrand
commented
Oct 8, 2024
R/label-compose.R
Outdated
| orig <- x | ||
| for (labeller in label_list) { | ||
| x <- labeller(x) | ||
| attr(x, "orig") <- orig |
There was a problem hiding this comment.
Attaching the original breaks as an attribute here so that 'aware' functions could use original numeric breaks if they've already been converted to character (when you need a number's sign or something)
There was a problem hiding this comment.
maybe something more specific than orig? orig_label is at least more descriptive
There was a problem hiding this comment.
I prefer orig_breaks then because we attach breaks and not labels as attributes. This confusion just go to show how orig was ambiguous 😅
Merge branch 'main' into compose_labels # Conflicts: # _pkgdown.yml
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aim to fix #462.
Briefly, it adds
compose_label()that you can use to chain together function to format your labels. This saves one the hassle of writing an anonymous function to inject in-between steps.@davidhodge931 this is a way to solve #443 too :)
Created on 2024-10-08 with reprex v2.1.1