Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unreachable branch of logic in recycle_common() #470

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

teunbrand
Copy link
Contributor

As pointed out off-github, there was a non-existing xs variable that was returned via recycle_common().
Upon further reflection, we can never reach the state wherein that value had to be returned, so in this PR we remove it.

@teunbrand teunbrand changed the title Remove branch of logic in recycle_common() Remove unreachable branch of logic in recycle_common() Oct 21, 2024
@thomasp85 thomasp85 merged commit bea228a into r-lib:main Oct 21, 2024
12 checks passed
@thomasp85
Copy link
Member

thank you

@teunbrand teunbrand deleted the trim_recycle_common_logic branch October 21, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants