Skip to content

Commit

Permalink
Windows: switch to toolchain libs for UCRT (#170)
Browse files Browse the repository at this point in the history
  • Loading branch information
jeroen authored Oct 6, 2023
1 parent 6c1d359 commit efb58f7
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 7 deletions.
7 changes: 2 additions & 5 deletions .github/workflows/R-CMD-check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,9 @@ jobs:
matrix:
config:
- {os: macos-latest, r: 'release'}

- {os: windows-latest, r: 'release'}
# Use 3.6 to trigger usage of RTools35
- {os: windows-latest, r: '3.6'}
# use 4.1 to check with rtools40's older compiler
- {os: windows-latest, r: '4.2', rtools: '42'}
- {os: windows-latest, r: '4.1'}

- {os: ubuntu-latest, r: 'devel', http-user-agent: 'release'}
- {os: ubuntu-latest, r: 'release'}
- {os: ubuntu-latest, r: 'oldrel-1'}
Expand All @@ -49,6 +45,7 @@ jobs:
- uses: r-lib/actions/setup-r@v2
with:
r-version: ${{ matrix.config.r }}
rtools-version: ${{ matrix.config.rtools }}
http-user-agent: ${{ matrix.config.http-user-agent }}
use-public-rspm: true

Expand Down
2 changes: 2 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# svglite (development version)

* Windows: use libpng included with Rtools on R 4.2 and up.

# svglite 2.1.1

* Fix `<cstdint>` include at request of CRAN
Expand Down
3 changes: 1 addition & 2 deletions src/Makevars.ucrt
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
CRT=-ucrt
include Makevars.win
PKG_LIBS = -lpng -lz

0 comments on commit efb58f7

Please sign in to comment.