diff --git a/R/browse.R b/R/browse.R index fc02f10c1..9f60298f3 100644 --- a/R/browse.R +++ b/R/browse.R @@ -198,12 +198,12 @@ github_url <- function(package = NULL) { ui_warn(" Package {ui_value(package)} has no GitHub URLs in DESCRIPTION Trying the GitHub CRAN mirror") - glue::glue("https://github.com/cran/{package}") + glue_chr("https://github.com/cran/{package}") } cran_home <- function(package = NULL) { package <- package %||% project_name() - glue::glue("https://cran.r-project.org/package={package}") + glue_chr("https://cran.r-project.org/package={package}") } # returns NULL, if no DESCRIPTION found diff --git a/R/github-actions.R b/R/github-actions.R index bac774bb5..bbb5423a1 100644 --- a/R/github-actions.R +++ b/R/github-actions.R @@ -231,7 +231,7 @@ use_tidy_github_actions <- function(ref = NULL) { "Remove existing {ui_path('.travis.yml')} and {ui_path('appveyor.yml')}?" )) { file_delete(old_configs[has_appveyor_travis]) - # TODO maybe add ui_path("README.Rmd")? + # TODO maybe add ui_path("README.Rmd") or ui_path("README.md")? ui_todo("Remove old badges from README") } } diff --git a/tests/testthat/test-browse.R b/tests/testthat/test-browse.R index bab15739c..bd3dffd68 100644 --- a/tests/testthat/test-browse.R +++ b/tests/testthat/test-browse.R @@ -107,7 +107,7 @@ test_that("browse_XXX() goes to correct URL", { expect_match(browse_github_actions("gh"), g("r-lib/gh/actions")) - expect_match(browse_cran("usethis"), "https://cran.r-project.org/package=usethis") + expect_equal(browse_cran("usethis"), "https://cran.r-project.org/package=usethis") }) test_that("browse_package() errors if no project", {