Skip to content

Commit

Permalink
Might as well always update license metadata
Browse files Browse the repository at this point in the history
  • Loading branch information
hadley committed Oct 30, 2023
1 parent 68efbdb commit a2fce6d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
7 changes: 1 addition & 6 deletions R/upkeep.R
Original file line number Diff line number Diff line change
Expand Up @@ -201,12 +201,6 @@ tidy_upkeep_checklist <- function(year = NULL,
with DESCRIPTION changes",
author_has_rstudio_email() || (posit_pkg && !posit_person_ok)
),
todo(
"
Double check license file uses '[package] authors' \\
as copyright holder. Run `use_mit_license()`",
grepl("MIT", desc$get_field("License"))
),
todo("
Update logo (https://github.com/rstudio/hex-stickers); \\
run `use_tidy_logo()`"),
Expand Down Expand Up @@ -241,6 +235,7 @@ tidy_upkeep_checklist <- function(year = NULL,
bullets,
"### Eternal",
"",
todo("`use_mit_license()`", grepl("MIT", desc$get_field("License"))),
todo('`use_package("R", "Depends", "{tidy_minimum_r_version()}")`'),
todo("`usethis::use_tidy_description()`"),
todo("`usethis::use_tidy_github_actions()`"),
Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/_snaps/upkeep.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
* [ ] Update email addresses *@rstudio.com -> *@posit.co
* [ ] Update copyright holder in DESCRIPTION: `person("Posit Software, PBC", role = c("cph", "fnd"))`
* [ ] `Run devtools::document()` to re-generate package-level help topic with DESCRIPTION changes
* [ ] Double check license file uses '[package] authors' as copyright holder. Run `use_mit_license()`
* [ ] Update logo (https://github.com/rstudio/hex-stickers); run `use_tidy_logo()`
* [ ] `usethis::use_tidy_coc()`
* [ ] Use `pak::pak("org/pkg")` in README
Expand All @@ -48,6 +47,7 @@
### Eternal
* [ ] `use_mit_license()`
* [ ] `use_package("R", "Depends", "3.6")`
* [ ] `usethis::use_tidy_description()`
* [ ] `usethis::use_tidy_github_actions()`
Expand Down

0 comments on commit a2fce6d

Please sign in to comment.