From a2fce6d2be806bd78d199bb67621e13cd78c8ae9 Mon Sep 17 00:00:00 2001
From: Hadley Wickham <h.wickham@gmail.com>
Date: Mon, 30 Oct 2023 16:19:43 -0500
Subject: [PATCH] Might as well always update license metadata

---
 R/upkeep.R                      | 7 +------
 tests/testthat/_snaps/upkeep.md | 2 +-
 2 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/R/upkeep.R b/R/upkeep.R
index 6a4a5efe6..5070eb4f8 100644
--- a/R/upkeep.R
+++ b/R/upkeep.R
@@ -201,12 +201,6 @@ tidy_upkeep_checklist <- function(year = NULL,
         with DESCRIPTION changes",
         author_has_rstudio_email() || (posit_pkg && !posit_person_ok)
       ),
-      todo(
-        "
-        Double check license file uses '[package] authors' \\
-        as copyright holder. Run `use_mit_license()`",
-        grepl("MIT", desc$get_field("License"))
-      ),
       todo("
         Update logo (https://github.com/rstudio/hex-stickers); \\
         run `use_tidy_logo()`"),
@@ -241,6 +235,7 @@ tidy_upkeep_checklist <- function(year = NULL,
     bullets,
     "### Eternal",
     "",
+    todo("`use_mit_license()`", grepl("MIT", desc$get_field("License"))),
     todo('`use_package("R", "Depends", "{tidy_minimum_r_version()}")`'),
     todo("`usethis::use_tidy_description()`"),
     todo("`usethis::use_tidy_github_actions()`"),
diff --git a/tests/testthat/_snaps/upkeep.md b/tests/testthat/_snaps/upkeep.md
index 870e5113e..032b59b55 100644
--- a/tests/testthat/_snaps/upkeep.md
+++ b/tests/testthat/_snaps/upkeep.md
@@ -36,7 +36,6 @@
       * [ ] Update email addresses *@rstudio.com -> *@posit.co
       * [ ] Update copyright holder in DESCRIPTION: `person("Posit Software, PBC", role = c("cph", "fnd"))`
       * [ ] `Run devtools::document()` to re-generate package-level help topic with DESCRIPTION changes
-      * [ ] Double check license file uses '[package] authors' as copyright holder. Run `use_mit_license()`
       * [ ] Update logo (https://github.com/rstudio/hex-stickers); run `use_tidy_logo()`
       * [ ] `usethis::use_tidy_coc()`
       * [ ] Use `pak::pak("org/pkg")` in README
@@ -48,6 +47,7 @@
       
       ### Eternal
       
+      * [ ] `use_mit_license()`
       * [ ] `use_package("R", "Depends", "3.6")`
       * [ ] `usethis::use_tidy_description()`
       * [ ] `usethis::use_tidy_github_actions()`