-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to @exportS3Method()
#1923
Comments
usethis:::tidy_minimum_r_version()
#> [1] '3.6' The case where we can't assume/require R >= 3.6 would be pretty exceptional at this point, yeah? I realize this might not just be about packages following the tidyverse policy, but I assume there aren't lots of packages that are intentionally trying to support R 3.5 or earlier. |
Oh yeah, I just forgot we can rely on 3.6 now. |
We don't really have to add this to upkeep since roxygen2 will warn about undocumented S3 methods, but it might be a nice reminder? |
@hadley Do you care to revisit / restate the call to action here? |
I think we can turn this into individual issues on specific repos. So the job for one of us is to:
|
Maybe we should back off on this because of https://bugs.r-project.org/show_bug.cgi?id=18776? |
And when |
If a package includes
register_s3()
and we can use R 3.6.The text was updated successfully, but these errors were encountered: