Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to @exportS3Method() #1923

Closed
hadley opened this issue Nov 21, 2023 · 7 comments
Closed

Switch to @exportS3Method() #1923

hadley opened this issue Nov 21, 2023 · 7 comments
Labels
feature a feature request or enhancement tidy ✨ tools for the tidyverse team upkeep 🧹

Comments

@hadley
Copy link
Member

hadley commented Nov 21, 2023

If a package includes register_s3() and we can use R 3.6.

@hadley hadley added feature a feature request or enhancement tidy ✨ tools for the tidyverse team upkeep 🧹 labels Nov 21, 2023
@jennybc
Copy link
Member

jennybc commented Nov 21, 2023

usethis:::tidy_minimum_r_version()
#> [1] '3.6'

The case where we can't assume/require R >= 3.6 would be pretty exceptional at this point, yeah? I realize this might not just be about packages following the tidyverse policy, but I assume there aren't lots of packages that are intentionally trying to support R 3.5 or earlier.

@hadley
Copy link
Member Author

hadley commented Nov 21, 2023

Oh yeah, I just forgot we can rely on 3.6 now.

@hadley
Copy link
Member Author

hadley commented Nov 22, 2023

We don't really have to add this to upkeep since roxygen2 will warn about undocumented S3 methods, but it might be a nice reminder?

@jennybc
Copy link
Member

jennybc commented Jul 22, 2024

@hadley Do you care to revisit / restate the call to action here?

@hadley
Copy link
Member Author

hadley commented Jul 22, 2024

I think we can turn this into individual issues on specific repos. So the job for one of us is to:

@hadley
Copy link
Member Author

hadley commented Oct 7, 2024

Maybe we should back off on this because of https://bugs.r-project.org/show_bug.cgi?id=18776?

@hadley
Copy link
Member Author

hadley commented Oct 7, 2024

And when @exportS3method fails it's really hard to realise/debug that the problem is an instance of this problem. And it doesn't really buy as anything so there's no reason to switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement tidy ✨ tools for the tidyverse team upkeep 🧹
Projects
None yet
Development

No branches or pull requests

2 participants