-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why use the h1 heder for each version of the NEWS.md? #1930
Comments
I don't really know why h1 was chosen here, but I think it would be pretty painful to do anything else at this point. There is code in usethis and pkgdown, just for starters, I imagine, that is built around this assumption. @hadley do you have any observations? |
Yeah h2 is arguably more correct, but it’s too late to change now. |
Would you add an opt-in option to use h2 headers, as having multiple h1 headers may cause various tools to not work well. |
This is going to be a bunch of work for us, so you'd need to provide compelling evidence that this is worth it. |
Currently when NEWS files are updated by usethis uses h1
#
for the heading of each version.usethis/R/news.R
Lines 36 to 59 in 709f825
But normally h1 is supposed to be used one for each page, wouldn't it be more natural to use h2?
Do you think it is worth having such an option to at least use h2
##
?The text was updated successfully, but these errors were encountered: