Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usethis theme i bullet #1965

Closed
olivroy opened this issue Mar 14, 2024 · 1 comment
Closed

usethis theme i bullet #1965

olivroy opened this issue Mar 14, 2024 · 1 comment

Comments

@olivroy
Copy link
Contributor

olivroy commented Mar 14, 2024

Is it worth overriding usethis i bullet to make it yellow.

FWIW, in most devtools / tidyverse packages, the blue default is used.
image

And with latest dev usethis, with pr_forget(), I saw a blue i

image

Feel free to close with no further explanation, just my 2 cents. I see that you added a justification in #1956 (comment)

Edit: I am also biased for having used my cli branch #1928 for a couple months, so I got used to blue i in usethis there too.

ui_abort() doesn't seem to have it either?

ui_abort() is also contrary to the default of cli_abort() by putting a x as the first bullet..

@jennybc
Copy link
Member

jennybc commented Jul 22, 2024

These moves are intentional. I don't feel strongly about the color of the "i". The ui_abort() behaviour is a more strongly held opinion. But I feel OK releasing as things are.

@jennybc jennybc closed this as not planned Won't fix, can't repro, duplicate, stale Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants