Merge pull request #64 from r3labs/patch-nil-pointer

assign an empty type when patch value is nil
r3labs · Jul 12, 2021 · 9d1db3b · 9d1db3b
2 parents 04a5761 + 5f0fcde
commit 9d1db3b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -1,4 +1,4 @@
-# Diff [![PkgGoDev](https://pkg.go.dev/badge/github.com/r3labs/diff)](https://pkg.go.dev/github.com/r3labs/diff) [![Go Report Card](https://goreportcard.com/badge/github.com/r3labs/diff)](https://goreportcard.com/report/github.com/r3labs/diff) [![Build Status](https://travis-ci.org/r3labs/diff.svg?branch=master)](https://travis-ci.org/r3labs/diff)
+# Diff [![PkgGoDev](https://pkg.go.dev/badge/github.com/r3labs/diff)](https://pkg.go.dev/github.com/r3labs/diff) [![Go Report Card](https://goreportcard.com/badge/github.com/r3labs/diff)](https://goreportcard.com/report/github.com/r3labs/diff) [![Build Status](https://travis-ci.com/r3labs/diff.svg?branch=master)](https://travis-ci.com/r3labs/diff)
 
 A library for diffing golang structures and values.
 

diff --git a/change_value.go b/change_value.go
@@ -123,7 +123,12 @@ func (c *ChangeValue) Set(value reflect.Value, convertCompatibleTypes bool) {
 			}
 			c.target.Set(value.Convert(c.target.Type()))
 		} else {
-			c.target.Set(value)
+			if value.IsValid() {
+				c.target.Set(value)
+			} else {
+				t := c.target.Elem()
+				t.Set(reflect.Zero(t.Type()))
+			}
 		}
 		c.SetFlag(FlagApplied)
 	}