Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a verbose message on duplicated and dropped observations after countryid standardization #21

Closed
anhqle opened this issue Jun 30, 2015 · 1 comment · Fixed by #24

Comments

@anhqle
Copy link
Contributor

anhqle commented Jun 30, 2015

When using psData, the user would frequently see messages such as:

37 duplicated values were created when standardising the country ID with iso2c.
59 observations dropped based on missing values of the standardised ID variable.

I think it would be a good idea to add a verbose option that allows user to know exactly which id has been dropped / duplicated due to transforming which type of country ID to another. It would add a lot of peace of mind. In my experience, I always go back to check what has been dropped manually.

If @christophergandrud think this is a good idea, I would be happy to contribute a pull request.

@christophergandrud
Copy link
Contributor

Sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants