Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

outlier alerts functionality duplicated #58

Open
raamana opened this issue Mar 30, 2022 · 0 comments
Open

outlier alerts functionality duplicated #58

raamana opened this issue Mar 30, 2022 · 0 comments

Comments

@raamana
Copy link
Owner

raamana commented Mar 30, 2022

the .add_alerts() and .update_alerts() methods of various workflows are exact duplicates! they can absorbed into the visualqc.base.BaseWorkflow class without any loss of functionality and avoid duplicated code. However, this requires proper testing on datasets where outlier detection module identifies some outliers etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@raamana