chore: pull_translations: use less Makefile commands and move it to P…

…ython `mkdir` should be in Python
raccoongang · Feb 19, 2024 · 25b3794 · 25b3794
1 parent 79d692d
commit 25b3794
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Makefile b/Makefile
@@ -65,10 +65,9 @@ pull_plugin_translations:  ## Pull translations from Transifex for edx_django_ut
 pull_xblock_translations:  ## pull xblock translations via atlas
 	rm -rf conf/plugins-locale/xblock.v1  # Clean up existing atlas translations
 	rm -rf lms/static/i18n/xblock.v1 cms/static/i18n/xblock.v1  # Clean up existing xblock compiled translations
-	mkdir -p conf/plugins-locale/xblock.v1/ lms/static/js/xblock.v1-i18n cms/static/js
 	python manage.py lms pull_xblock_translations --verbose $(ATLAS_OPTIONS)
 	python manage.py lms compile_xblock_translations
-	cp -r lms/static/js/xblock.v1-i18n cms/static/js
+	python manage.py cms compile_xblock_translations
 
 pull_translations: ## pull translations from Transifex
 	git clean -fdX conf/locale

diff --git a/openedx/core/djangoapps/plugins/i18n_api.py b/openedx/core/djangoapps/plugins/i18n_api.py
@@ -92,6 +92,7 @@ def ensure_empty_directory(self, directory):
         Ensure the pull directory is empty before running atlas pull.
         """
         plugin_translations_root = directory
+        os.makedirs(plugin_translations_root, exist_ok=True)
         if os.listdir(plugin_translations_root):
             raise CommandError(f'"{plugin_translations_root}" should be empty before running atlas pull.')