feat: [AXIMST-538] Add errors handling 4xx, 5xx #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruzniaievdm
force-pushed
the
ruzniaievdm/feat/saving-error-notification
branch
2 times, most recently
from
a9c5255 to
0b2fd90
Compare
ruzniaievdm
force-pushed
the
ruzniaievdm/feat/saving-error-notification
branch
from
0b2fd90 to
d2e8321
Compare
ihor-romaniuk
force-pushed
the
ts-develop
branch
from
f0efff1 to
1d1c07d
Compare
ruzniaievdm
force-pushed
the
ruzniaievdm/feat/saving-error-notification
branch
2 times, most recently
from
7f7ef08 to
d902e05
Compare
ruzniaievdm
requested review from
ihor-romaniuk,
monteri,
khudym,
PKulkoRaccoonGang and
vladislavkeblysh
PKulkoRaccoonGang
requested changes
Mar 5, 2024
src/generic/saving-error-notification/SavingErrorNotification.jsx
Outdated
Show resolved
Hide resolved
src/generic/saving-error-notification/SavingErrorNotification.jsx
Outdated
Show resolved
Hide resolved
ruzniaievdm
force-pushed
the
ruzniaievdm/feat/saving-error-notification
branch
from
d902e05 to
639f9bc
Compare
ruzniaievdm
force-pushed
the
ruzniaievdm/feat/saving-error-notification
branch
from
639f9bc to
b8c1854
Compare
monteri
reviewed
Mar 5, 2024
| @@ -2,6 +2,7 @@ import PropTypes from 'prop-types'; | |||
| import { Container, Layout } from '@openedx/paragon'; | |||
| import { useIntl } from '@edx/frontend-platform/i18n'; | |||
|
|
|||
| import { SavingErrorNotification } from '../../generic/saving-error-notification'; | |||
There was a problem hiding this comment.
I think the name is appropriate for other developers to look up when they will search for such component on other pages. I would regard SavingErrorAlert since "alert" is rather more appropriate for an "error" than a "notification". But I would leave this choice for you wether to do refactor or not.
| import AlertMessage from '../alert-message'; | ||
| import messages from './messages'; | ||
|
|
||
| const SavingErrorNotification = ({ |
There was a problem hiding this comment.
[question] So now this component handles both 4xx, 5xx errors and internet connection too?
There was a problem hiding this comment.
Yeap, it used only for new scope
| <SavingErrorNotification | ||
| savingStatus={savingStatus} | ||
| errorMessage={errorMessage} | ||
| /> | ||
| <InternetConnectionAlert |
There was a problem hiding this comment.
Do we need to remove InternetConnectionAlert as it is removed on the other pages?
PKulkoRaccoonGang
approved these changes
Mar 5, 2024
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## ts-develop #196 +/- ##
=============================================
Coverage ? 89.52%
=============================================
Files ? 651
Lines ? 10878
Branches ? 2252
=============================================
Hits ? 9739
Misses ? 1100
Partials ? 39 ☔ View full report in Codecov by Sentry. |
monteri
approved these changes
Mar 6, 2024
khudym
pushed a commit
that referenced
this pull request
Mar 25, 2024
* feat: [AXIMST-538] Add errors handling 4xx, 5xx * fix: resolve discussions * fix: second round of review discussions
monteri
pushed a commit
that referenced
this pull request
Apr 1, 2024
* feat: [AXIMST-538] Add errors handling 4xx, 5xx * fix: resolve discussions * fix: second round of review discussions
monteri
pushed a commit
that referenced
this pull request
Apr 29, 2024
* feat: [AXIMST-538] Add errors handling 4xx, 5xx * fix: resolve discussions * fix: second round of review discussions
monteri
pushed a commit
that referenced
this pull request
May 3, 2024
* feat: [AXIMST-538] Add errors handling 4xx, 5xx * fix: resolve discussions * fix: second round of review discussions
PKulkoRaccoonGang
pushed a commit
that referenced
this pull request
May 9, 2024
* feat: [AXIMST-538] Add errors handling 4xx, 5xx * fix: resolve discussions * fix: second round of review discussions
PKulkoRaccoonGang
pushed a commit
that referenced
this pull request
May 9, 2024
* feat: [AXIMST-538] Add errors handling 4xx, 5xx * fix: resolve discussions * fix: second round of review discussions refactor: fixing tests for Textbooks page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add-errors-handling-4xx-5xx