-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [ACI-139, ACI-145] new events for badge #4
Conversation
@kyrylo-kh there are failed tests, pls fix'em. |
cd8bdd8
to
2b4563f
Compare
df7d4a8
to
69e0da9
Compare
69e0da9
to
3de6c3e
Compare
openedx_events/learning/data.py
Outdated
|
||
uuid = attr.ib(type=str) | ||
type = attr.ib(type=str) | ||
name = attr.ib(type=str) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is expected to be optional.
openedx_events/learning/data.py
Outdated
uuid = attr.ib(type=str) | ||
type = attr.ib(type=str) | ||
name = attr.ib(type=str) | ||
description = attr.ib(type=str) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is expected to be optional.
openedx_events/learning/data.py
Outdated
type = attr.ib(type=str) | ||
name = attr.ib(type=str) | ||
description = attr.ib(type=str) | ||
image_url = attr.ib(type=str) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is expected to be optional.
3de6c3e
to
8951bef
Compare
* feat: [ACI-75] new public events * feat: [ACI-139, ACI-145] new events for badge
* feat: [ACI-75] new public events * feat: [ACI-139, ACI-145] new events for badge
* feat: [ACI-75] new public events * feat: [ACI-139, ACI-145] new events for badge
https://youtrack.raccoongang.com/issue/ACI-139
https://youtrack.raccoongang.com/issue/ACI-145