Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [ACI-139, ACI-145] new events for badge #4

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

@wowkalucky
Copy link

@kyrylo-kh there are failed tests, pls fix'em.

@kyrylo-kh kyrylo-kh force-pushed the kholodenko/aci-75/new-events-grade-now-passed-failed branch 3 times, most recently from cd8bdd8 to 2b4563f Compare January 12, 2024 14:50
@kyrylo-kh kyrylo-kh force-pushed the kholodenko/aci-139/new-event-badge branch 4 times, most recently from df7d4a8 to 69e0da9 Compare January 12, 2024 15:07
Base automatically changed from kholodenko/aci-75/new-events-grade-now-passed-failed to aci.main January 15, 2024 15:23
openedx_events/learning/data.py Show resolved Hide resolved
openedx_events/learning/data.py Outdated Show resolved Hide resolved
@kyrylo-kh kyrylo-kh force-pushed the kholodenko/aci-139/new-event-badge branch from 69e0da9 to 3de6c3e Compare January 16, 2024 09:33

uuid = attr.ib(type=str)
type = attr.ib(type=str)
name = attr.ib(type=str)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is expected to be optional.

uuid = attr.ib(type=str)
type = attr.ib(type=str)
name = attr.ib(type=str)
description = attr.ib(type=str)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is expected to be optional.

type = attr.ib(type=str)
name = attr.ib(type=str)
description = attr.ib(type=str)
image_url = attr.ib(type=str)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is expected to be optional.

@kyrylo-kh kyrylo-kh force-pushed the kholodenko/aci-139/new-event-badge branch from 3de6c3e to 8951bef Compare January 16, 2024 09:59
@wowkalucky wowkalucky merged commit 0265802 into aci.main Jan 16, 2024
4 checks passed
@wowkalucky wowkalucky deleted the kholodenko/aci-139/new-event-badge branch January 16, 2024 11:06
wowkalucky pushed a commit that referenced this pull request Feb 23, 2024
* feat: [ACI-75] new public events

* feat: [ACI-139, ACI-145] new events for badge
wowkalucky pushed a commit that referenced this pull request Mar 26, 2024
* feat: [ACI-75] new public events

* feat: [ACI-139, ACI-145] new events for badge
kyrylo-kh added a commit that referenced this pull request Apr 14, 2024
* feat: [ACI-75] new public events

* feat: [ACI-139, ACI-145] new events for badge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants