Skip to content

Commit

Permalink
chore: remove Makefile PACKAGES (celestiaorg#852)
Browse files Browse the repository at this point in the history
I noticed that we no longer need a Makefile `PACKAGES` variable because
this repo doesn't contain a `/simulation` directory. We removed sims
from workflows in celestiaorg#697
but there wasn't a `/simulation` directory then either.

This makes the `make test` command easier to copy + paste (if for
instance you want to add a trailing `-count=1` flag to disable the
cache)

Note: cosmos-sdk uses PACKAGE variables
[here](https://github.com/cosmos/cosmos-sdk/blob/main/Makefile#L3-L4)
but celestia-app doesn't appear to need this extra complexity
  • Loading branch information
rootulp authored and rach-id committed Nov 16, 2022
1 parent 5f82f60 commit c24ff39
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
#!/usr/bin/make -f

PACKAGES=$(shell go list ./... | grep -v '/simulation')
VERSION := $(shell echo $(shell git describe --tags) | sed 's/^v//')
COMMIT := $(shell git log -1 --format='%H')
DOCKER := $(shell which docker)
Expand Down Expand Up @@ -45,7 +44,7 @@ go.sum: mod
GO111MODULE=on go mod verify

test:
@go test -mod=readonly $(PACKAGES)
@go test -mod=readonly ./...
.PHONY: test

proto-gen:
Expand Down

0 comments on commit c24ff39

Please sign in to comment.