Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUESTION] How to use 'make deploy' in Windows #1519

Open
FrankAllotta opened this issue Jul 29, 2022 · 1 comment
Open

[QUESTION] How to use 'make deploy' in Windows #1519

FrankAllotta opened this issue Jul 29, 2022 · 1 comment
Labels
priority:low Low priority issue or pull request question Further information is requested status:review_needed Issue or pull request needs reviewed

Comments

@FrankAllotta
Copy link

Question

How do you use 'make deploy' in windows when using a make file?

Context

I have a make file set up and I am trying to run 'make deploy-vpc' from the windows command line. I have Make installed via choco but I receive the following error.

C:\Users<USER>\Projects\vpc-tf>make deploy-vpc
DEPLOY_ENVIRONMENT=common runway deploy --tag vpc
'DEPLOY_ENVIRONMENT' is not recognized as an internal or external command,
operable program or batch file.
make: *** [Makefile:4: deploy-vpc] Error 1

This is the content of the make file.

deploy-vpc:
DEPLOY_ENVIRONMENT=common runway deploy --tag vpc

I'm guessing this is due to some inherent issue with the way Windows uses environment variables on the command line?

@FrankAllotta FrankAllotta added priority:low Low priority issue or pull request question Further information is requested status:review_needed Issue or pull request needs reviewed labels Jul 29, 2022
@mbordash2
Copy link
Contributor

Hi Frank,
You may be on the right track with how Windows manages env variables, I'll have to track down a Windows env to test with, but can you just update your command to pass in the env like this instead?

poetry run runway plan --deploy-environment test
[runway] deploy environment "test" is explicitly defined in the environment
[runway] if not correct, update the value or unset it to fall back to the name of the current git branch or parent directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low Low priority issue or pull request question Further information is requested status:review_needed Issue or pull request needs reviewed
Projects
Status: Backlog
Development

No branches or pull requests

2 participants