Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Update awslambda sampleapp to support newer requests library #2041

Closed
jake-skipper opened this issue Dec 5, 2023 · 1 comment
Closed

[BUG] Update awslambda sampleapp to support newer requests library #2041

jake-skipper opened this issue Dec 5, 2023 · 1 comment
Labels
bug Something isn't working priority:low Low priority issue or pull request status:review_needed Issue or pull request needs reviewed

Comments

@jake-skipper
Copy link
Contributor

Bug Description

In tests/functional/cfngin/hooks/test_awslambda/sample_app/src/docker/requirements.txt the requests library is defined. We've temporarily pinned it to a version before they added urllib3 version 2 support. When unpinned, the latest version is installed which results in the following error when executing in AWS Lambda:

urllib3 v2 only supports OpenSSL 1.1.1+, currently the 'ssl' module is compiled with 'OpenSSL 1.0.2k-fips  26 Jan 2017'. See: https://github.com/urllib3/urllib3/issues/2168

The awslambda unit tests appear to use a lambda layer for dependencies. We need to work out how to update the ssl module before we can roll requests forward.

Dependabot would also like to roll this forward, but if we do it will break things. see #2036

Expected Behavior

Latest version of requests library should import without an OpenSSL version error caused by urllib3 v2.

Steps To Reproduce

Read bug description.

Runway version

2.6.11

Installation Type

pypi (pip, pipenv, poetry, etc)

OS / Environment

Any

Anything else?

No response
@jake-skipper jake-skipper added bug Something isn't working priority:low Low priority issue or pull request status:review_needed Issue or pull request needs reviewed labels Dec 5, 2023
@jake-skipper
Copy link
Contributor Author

Resolved in #2036

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working priority:low Low priority issue or pull request status:review_needed Issue or pull request needs reviewed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jake-skipper