Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Expand CFNgin config name exclusion to add docker-compose(..*)? #2411

Open
sam-fakhreddine opened this issue Jun 28, 2024 · 1 comment
Assignees
Labels
bug Something isn't working status:accepted Issue or pull request accepted by maintainer
Milestone

Comments

@sam-fakhreddine
Copy link
Contributor

Description: [BUG] Expand CFNgin config name exclusion to add docker-compose(..*)?

@sam-fakhreddine sam-fakhreddine added the bug Something isn't working label Jun 28, 2024
@ITProKyle ITProKyle added status:accepted Issue or pull request accepted by maintainer priority:low Low priority issue or pull request labels Jul 18, 2024
@ITProKyle ITProKyle moved this to Backlog in Runway Development Work Sep 4, 2024
@ITProKyle ITProKyle moved this from Backlog to To do in Runway Development Work Sep 4, 2024
@ITProKyle ITProKyle added this to the v2.8 milestone Jan 8, 2025
@ITProKyle
Copy link
Collaborator

The change will need to take place here:

EXCLUDE_REGEX = r"runway(\..*)?\.(yml|yaml)"
"""Regex for file names to exclude when looking for config files."""
EXCLUDE_LIST = ["bitbucket-pipelines.yml", "buildspec.yml", "docker-compose.yml"]
"""Explicit files names to ignore when looking for config files."""

It would also be nice to turn both of these into ClassVars

    EXCLUDE_REGEX: ClassVar[str] = (
        r"(?x)^(bitbucket-pipelines|buildspec|docker-compose|runway)(\..*)?\.(yml|yaml)"
    )
    """Regex for file names to exclude when looking for config files."""

    EXCLUDE_LIST: ClassVar[list[str]] = []
    """Explicit files names to ignore when looking for config files."""

EXCLUDE_LIST can be made irrelevant by improving the regex. It's probably safe to remove or it can be retained till the next major release with a note added to remove it.

@ITProKyle ITProKyle removed the priority:low Low priority issue or pull request label Feb 11, 2025
@mbordash2 mbordash2 self-assigned this Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status:accepted Issue or pull request accepted by maintainer
Projects
Status: To do
Development

No branches or pull requests

3 participants