-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't work in IE8. #6
Comments
Seems that XMLHttpRequest isn't defined (at least, the normal way) in IE7/8: http://stackoverflow.com/questions/2363212/window-xmlhttprequest-is-undefined-in-ie7-ie8 We could also check for ActiveXObject but maybe it would be better to switch to a proper AJAX micro-lib? |
i am thinking safari has the same problem |
@violinchris The problem with Safari has been solved (#9). We'll need to use |
Maybe the best solution is to expose the Ractive.load.get = function ( url ) {
return new Ractive.Promise( function ( fulfil, reject ) {
// use library of choice
var request = someAjaxLib({
url: url,
onload: function () {
fulfil( request.response );
},
onerror: reject
});
});
}; It'd be a shame to have to include another lib just to support a handful of laggards. Or maybe we have two build targets with different requirejs configs - i.e. add a sibling to get: 'utils/get-legacy' Then we could include a proper AJAX micro-lib (I assume, given that there's so many of them, that there's a bit of work involved in getting |
@Rich-Harris I'm not 100 % sure, but I think that |
The text was updated successfully, but these errors were encountered: