Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] UI #47

Merged
merged 1 commit into from
Sep 11, 2024
Merged

[WIP] UI #47

merged 1 commit into from
Sep 11, 2024

Conversation

dnakov
Copy link
Collaborator

@dnakov dnakov commented Sep 10, 2024

Just bringing the PR for visibility. Still WIP, but could technically be merged as it's mostly separate stuff at the moment.

@trufae
Copy link
Contributor

trufae commented Sep 11, 2024

Im not a big fan of having large single commits because its hard to review and keep up when the codebase is changing. So imho i would prefer to merge it and push more stuff later on separate prs

@dnakov
Copy link
Collaborator Author

dnakov commented Sep 11, 2024

Agreed. Let's merge then, its the base for the UI. It uses a separate chat function and models list, so not fully integrated but I'll do those in new PRs

@trufae trufae merged commit 9237600 into radareorg:master Sep 11, 2024
1 check passed
@trufae
Copy link
Contributor

trufae commented Sep 11, 2024

It’s in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants