Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align capitalize with the built-in Capitalize<T> TypeScript type #42

Closed
aleclarson opened this issue Jun 28, 2024 · 0 comments
Closed

Comments

@aleclarson
Copy link
Member

aleclarson commented Jun 28, 2024

As I mentioned on @rafawendel's Radash PR, the current capitalize differs in behavior from TypeScript's Capitalize<T> built-in type.

The built-in Capitalize type does not match the behavior of Radash capitalize.

type Foo = Capitalize<'foo Bar'>
//   ^? 'Foo Bar'

let foo = _.capitalize('foo Bar')
// => 'Foo bar'

I suggest we change Radashi's capitalize to align with it.

@aleclarson aleclarson added BREAKING CHANGE Not backwards compatible stage 0: proposed A proposal for a change that is offered for community and team evaluation. labels Jun 28, 2024
@radashi-org radashi-org locked and limited conversation to collaborators Jun 28, 2024
@aleclarson aleclarson converted this issue into discussion #47 Jun 28, 2024
@aleclarson aleclarson removed BREAKING CHANGE Not backwards compatible stage 0: proposed A proposal for a change that is offered for community and team evaluation. labels Jun 28, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant