Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional tests #35

Open
dtabell opened this issue Aug 2, 2018 · 5 comments
Open

Additional tests #35

dtabell opened this issue Aug 2, 2018 · 5 comments
Assignees
Milestone

Comments

@dtabell
Copy link
Contributor

dtabell commented Aug 2, 2018

Add two more tests, to bring the total up too three. I'll look at the examples.

The goal here is to have a clear framework for adding tests in the future.

@dtabell dtabell added this to the SOW 2 milestone Aug 2, 2018
@rouson rouson self-assigned this Sep 18, 2018
@zbeekman zbeekman self-assigned this Sep 25, 2018
@rouson
Copy link
Contributor

rouson commented Sep 26, 2018

I'm capturing the TODO lists from the spinESRF_18GeV and spinSaturne tests here to

  1. Exploit GitHub's issue progress bar and Markdown capabilities,
  2. Eliminate the need for committing and tracking temporary TODO files, and
  3. Gather all the TODO items related to this issue in one place.

spinESRF_18GeV To Do List

  • Make sure we point to the correct zgoubi executable.
  • Recheck the expected results after we update the various physical constants defined by zgoubi.
  • Add color, etc, to output of test script.

spinSaturne To Do List

  • Make sure we point to the correct zgoubi executable.
  • Recheck the expected results after we update the various physical constants defined by zgoubi.
  • Add color, etc, to output of test script.
  • Fix X2 scale in the plot.

rouson added a commit that referenced this issue Sep 26, 2018
The information from these 2 files is now captured in issue #35
on GitHub.
@rouson
Copy link
Contributor

rouson commented Oct 4, 2018

@dtabell I've checked off the items in the above comment's To Do lists to reflect the current status of the commits that I just merged into the add-zgoubi-tests branch. I'll need guidance from you to proceed on the unchecked boxes.

@rouson
Copy link
Contributor

rouson commented Oct 12, 2018

The work on this issue is ready for review.

@rouson
Copy link
Contributor

rouson commented Dec 12, 2018

@dtabell Let us know any of your thoughts upon reviewing the work on this issue. I'm not sure of the status of the unchecked boxes. If those are still requirements, I'll need further guidance on next steps.

@dtabell
Copy link
Contributor Author

dtabell commented Dec 12, 2018

Items remaining in the above ToDo lists are my responsibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants