Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IconButton should allow non-material icons #103

Open
Vehmloewff opened this issue Aug 10, 2019 · 1 comment
Open

IconButton should allow non-material icons #103

Vehmloewff opened this issue Aug 10, 2019 · 1 comment
Labels
enhancement Feature request that is not a new component

Comments

@Vehmloewff
Copy link
Member

I am not sure how would be done, but It would be really handy.

@Vehmloewff Vehmloewff added the enhancement Feature request that is not a new component label Aug 10, 2019
@Vehmloewff Vehmloewff changed the title IconButton should allow fontawesome icons IconButton should allow non-material icons Sep 9, 2019
@Vehmloewff
Copy link
Member Author

There could be a custom prop that defaults to false.

If custom add the value of icon to the class list on i.
Else use the the material icons.

A Fontawesome implementation would look like this:

<IconButton
	custom
	name="fas fa-star"
/>

This adds great flexibility as well as ease of use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request that is not a new component
Projects
None yet
Development

No branches or pull requests

1 participant