Add versions in PR title

radical · Aug 21, 2023 · e0dfbfe · e0dfbfe
1 parent 46a8acc
commit e0dfbfe
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/.github/workflows/bump-chrome-version.yml b/.github/workflows/bump-chrome-version.yml
@@ -26,7 +26,8 @@ jobs:
         run: >-
           make -C src/mono/wasm build-tasks &&
           .dotnet/dotnet build eng/testing/bump-chrome-version.proj -p:Configuration=Release &&
-          git add eng/testing/ChromeVersions.props
+          git add eng/testing/ChromeVersions.props &&
+          cat eng/testing/bump-chrome-pr.env >> "$GITHUB_ENV"
 
       - name: Check for changes
         id: check_changes
@@ -48,12 +49,13 @@ jobs:
         uses: actions/github-script@v6
         with:
           script: |
+            const { CHROME_LINUX_VER, CHROME_WIN_VER } = process.env
             const { data: pullRequest } = await github.rest.pulls.create({
               base: context.ref,
               head: "update-chrome-version-${{ github.run_id }}",
               owner: context.repo.owner,
               repo: context.repo.repo,
-              title: '[wasm] Bump chrome version used for testing',
+              title: '[wasm] Bump chrome for testing - linux: ${CHROME_LINUX_VER}, windows: ${CHROME_WIN_VER}',
               body: ''
             });
             await github.rest.issues.setLabels({

diff --git a/eng/testing/bump-chrome-version.proj b/eng/testing/bump-chrome-version.proj
@@ -42,9 +42,19 @@
   &lt;/PropertyGroup&gt;
 &lt;/Project&gt;
       </_PropsContent>
+
+      <!-- ensure newline at the end -->
+      <EnvVarsForPR>
+        CHROME_LINUX_VER=$(linux_ChromeVersion)
+        CHROME_WIN_VER=$(win_ChromeVersion)
+
+      </EnvVarsForPR>
     </PropertyGroup>
+
     <Message Text="Writing version props: $(_PropsContent)" Importance="High" />
     <WriteLinesToFile Lines="$(_PropsContent)" File="$(RepositoryEngineeringDir)testing\ChromeVersions.props" Overwrite="true" />
+
+    <WriteLinesToFile Lines="$(EnvVarsForPR)" File="$(RepositoryEngineeringDir)testing\bump-chrome-pr.env" Overwrite="true" />
   </Target>
 
   <Import Project="..\..\Directory.Build.targets" />