Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review types exposed by ReadOnly #710

Open
FintanH opened this issue Jun 19, 2021 · 0 comments
Open

Review types exposed by ReadOnly #710

FintanH opened this issue Jun 19, 2021 · 0 comments

Comments

@FintanH
Copy link
Contributor

FintanH commented Jun 19, 2021

The ReadOnlyStorage trait exposes some git2 types which allow mutation to the store. For example, a &mut reference to a git2::Reference will allow the caller to delete that reference.

It's not really possible to completely stop someone from doing this since they can always drop down through the git2 API (or any other for that matter), however, if we provide types that prohibit these actions then we can encourage someone from not doing something like that :)

@FintanH FintanH changed the title Review types exported by ReadOnly Review types exposed by ReadOnly Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant