Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog should have an option for a close button in the corner #630

Open
merlinstardust opened this issue Nov 16, 2024 · 0 comments
Open

Comments

@merlinstardust
Copy link

Currently Dialog has no close buttons and you have to create them yourself. This is fine for when you want to have a cancel button or similar at the bottom of the modal because that often changes between implementations. Some people might put close or cancel or any number of things.

But most modals have an X in the corner for closing it as well as a button at the bottom. While I can add this myself, I am very confident that this is code that a lot of people are writing for their dialogs, and thus it should be built in to the dialog itself.

It doesn't have to be the default, but one should be able to <Dialog.Root showClosingCornerX> and have it appear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant