Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rock Pi S CPU settings #41

Open
BigMuscle85 opened this issue Dec 5, 2023 · 8 comments
Open

Rock Pi S CPU settings #41

BigMuscle85 opened this issue Dec 5, 2023 · 8 comments

Comments

@BigMuscle85
Copy link

When building the image for Rock Pi S, it does not provide full CPU functionality:

  • CPU runs on 1 GHz maximally although it should be 1.3GHz
rock@rock-pi-s:~$ cat /sys/devices/system/cpu/cpufreq/policy0/scaling_available_frequencies
408000 600000 816000 1008000
  • CPU temperature not available and thermal zones in /sys/class/thermal/ are missing. This is related to the following errors reported in the kernel log. The problem here is that kernel 6.x requires 'trips' to be defined for all thermal zones else it won't load them at all.

[ 14.912964] thermal_sys: Failed to find 'trips' node
[ 14.913472] thermal_sys: Failed to find trip points for tsadc id=0
[ 14.914068] rockchip-thermal ff1f0000.tsadc: failed to register sensor 0: -22
[ 14.914737] rockchip-thermal ff1f0000.tsadc: failed to register sensor[0] : error = -22

https://github.com/radxa-repo/bsp/blob/main/linux/.stable-6.1/0023-armbian-rockpi-s/board-rockpis-0007-arm64-dts-rockchip-add-cpu-s-thermal-config-for-rk33.patch#L56

I've created an additional overlay to make this work:

/dts-v1/;
/plugin/;

/ {
    compatible = "rockchip,rk3308";

    fragment@0 {
                target = <&thermal_zones>;
                __overlay__ {
                        logic-thermal {
                                thermal-sensors = <&tsadc 0>;

                                trips {
                                        temp_crit: temp_crit {
                                               temperature = <90000>;
                                               hysteresis = <2000>;
                                               type = "critical";
                                        };
                                };
                        };
                };
    };
};
@RadxaYuntian
Copy link
Member

CPU runs on 1 GHz maximally although it should be 1.3GHz

Only RK3308B-S variant could support this speed. If your ROCK Pi S is indeed using that SoC, you can use this overlay.

Prebuilt dtbo are available in GitHub Workflow's artifact section.

CPU temperature not available and thermal zones in /sys/class/thermal/ are missing. This is related to the following errors reported in the kernel log. The problem here is that kernel 6.x requires 'trips' to be defined for all thermal zones else it won't load them at all.

Thanks for spotting this. I'll add this to our source tomorrow.

@BigMuscle85
Copy link
Author

Thank you for the information. I didn't know that B-S variant is needed for 1.3 GHz as doc here https://wiki.radxa.com/RockpiS does not mention it.
There's RK3308B written on my chip (board is V1.3) and running Armbian with 1.3 GHz overlay runs correctly even under heavy load. But on Radxa image, rsetup does not offer the overlay to be enabled at all, so I guess I need to enable it manually?

@RadxaYuntian
Copy link
Member

We have ceased RK3308B-S production due to many incompatibilities with existing RK3308 design, so I very much doubt yours is indeed 3308B-S. Having RK3308B written on it does not mean it is the B-S variant.

RK3308B-S either says RK3308B-S directly on the chip, or says RK3308B, but the second line will ends with S before the production week begins.

Given below chip as an example, the 2nd line is SBAKW05003. Since it is ending with 3 it is not RK3308B-S.

image

@BigMuscle85
Copy link
Author

You are right. Our chips also ends with 3 and not S. So it's definitely not B-S version. It is just a bit confusing because the official documentation on Radxa website talks about 1.3 GHz regardless the chip version and also the vendor sells all Rock Pi S as 1.3 GHz CPU. So the specified frequency is not correct and all boards now support only 1 GHz?

@RadxaYuntian
Copy link
Member

I'd think so. If you can please send me the links of 1.3 GHz so I could get them updated.

@BigMuscle85
Copy link
Author

It is here:
https://wiki.radxa.com/RockpiS/getting_started
https://radxa.com/products/rocks/pis
https://radxa.com/products/rocks/pis#techspec

  • Product Brief PDF downloadable on that website

This doc says that revisions 1.3 since 2022 (ours are V1.3, week 2311) are B-S - https://wiki.radxa.com/RockpiS/hardware/revisions

@RadxaYuntian
Copy link
Member

Thanks. @melooooooooooo please take a look at this.

@melooooooooooo
Copy link

Thank you for your support of Radxa.
The information you mentioned has been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants