cpufreq: rockchip: fix incorrect config flag #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the `CONFIG_ARCH_ROCKCHIP` flag for function calls to `rockchip_cpufreq_online` and `rockchip_cpufreq_offline` is incorrect. These functions are declared under the `CONFIG_ARM_ROCKCHIP_CPUFREQ` flag. As a result, using `CONFIG_ARCH_ROCKCHIP` can lead to implicit declaration errors if the correct config flag (`CONFIG_ARM_ROCKCHIP_CPUFREQ`) is not enabled. This patch updates the conditional preprocessor directive to use `CONFIG_ARM_ROCKCHIP_CPUFREQ`, ensuring consistency with the function declarations and preventing potential compilation issues. Signed-off-by: Ajit Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
CONFIG_ARCH_ROCKCHIPflag for function calls torockchip_cpufreq_onlineandrockchip_cpufreq_offlineis incorrect. These functions are declared under theCONFIG_ARM_ROCKCHIP_CPUFREQflag 1. As a result, usingCONFIG_ARCH_ROCKCHIPcan lead to implicit declaration errors if the correct config flag (CONFIG_ARM_ROCKCHIP_CPUFREQ) is not enabled.This patch updates the conditional preprocessor directive to use
CONFIG_ARM_ROCKCHIP_CPUFREQ, ensuring consistency with the function declarations and preventing potential compilation issues.