From 704cb8682dd26ad333f18be475ecb6f7609ce5b5 Mon Sep 17 00:00:00 2001
From: Ezequiel Salas <salaseze@gmail.com>
Date: Fri, 5 Apr 2024 18:52:16 -0300
Subject: [PATCH 01/24] jobs_relation finished_at_start and finished_at_end
 filters

---
 lib/active_job/jobs_relation.rb | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/lib/active_job/jobs_relation.rb b/lib/active_job/jobs_relation.rb
index 60cb1abc..d773c691 100644
--- a/lib/active_job/jobs_relation.rb
+++ b/lib/active_job/jobs_relation.rb
@@ -23,9 +23,9 @@ class ActiveJob::JobsRelation
   include Enumerable
 
   STATUSES = %i[ pending failed in_progress blocked scheduled finished ]
-  FILTERS = %i[ queue_name job_class_name ]
+  FILTERS = %i[ queue_name job_class_name finished_at_start finished_at_end ]
 
-  PROPERTIES = %i[ queue_name status offset_value limit_value job_class_name worker_id recurring_task_id ]
+  PROPERTIES = %i[ queue_name status offset_value limit_value job_class_name worker_id recurring_task_id finished_at_start finished_at_end ]
   attr_reader *PROPERTIES, :default_page_size
 
   delegate :last, :[], :reverse, to: :to_a
@@ -51,12 +51,14 @@ def initialize(queue_adapter: ActiveJob::Base.queue_adapter, default_page_size:
   # * <tt>:queue_name</tt> - To only include the jobs in the provided queue.
   # * <tt>:worker_id</tt> - To only include the jobs processed by the provided worker.
   # * <tt>:recurring_task_id</tt> - To only include the jobs corresponding to runs of a recurring task.
-  def where(job_class_name: nil, queue_name: nil, worker_id: nil, recurring_task_id: nil)
+  def where(job_class_name: nil, queue_name: nil, worker_id: nil, recurring_task_id: nil, finished_at_start: nil, finished_at_end: nil)
     # Remove nil arguments to avoid overriding parameters when concatenating +where+ clauses
     arguments = { job_class_name: job_class_name,
       queue_name: queue_name,
       worker_id: worker_id,
-      recurring_task_id: recurring_task_id
+      recurring_task_id: recurring_task_id,
+      finished_at_start: finished_at_start,
+      finished_at_end: finished_at_end
     }.compact.collect { |key, value| [ key, value.to_s ] }.to_h
 
     clone_with **arguments

From 5ca06820488000920ddbe20e023ebf7f67509bdc Mon Sep 17 00:00:00 2001
From: Ezequiel Salas <salaseze@gmail.com>
Date: Fri, 5 Apr 2024 18:52:29 -0300
Subject: [PATCH 02/24] natively_supported finished_at_* filters for
 solid_queue

---
 .../queue_adapters/solid_queue_ext.rb           | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/lib/active_job/queue_adapters/solid_queue_ext.rb b/lib/active_job/queue_adapters/solid_queue_ext.rb
index 25ec93bc..b69dc2cd 100644
--- a/lib/active_job/queue_adapters/solid_queue_ext.rb
+++ b/lib/active_job/queue_adapters/solid_queue_ext.rb
@@ -40,7 +40,7 @@ def supported_job_statuses
   end
 
   def supported_job_filters(*)
-    [ :queue_name, :job_class_name ]
+    [ :queue_name, :job_class_name, :finished_at_start, :finished_at_end ]
   end
 
   def jobs_count(jobs_relation)
@@ -169,7 +169,7 @@ def retry_all
         attr_reader :jobs_relation
 
         delegate :queue_name, :limit_value, :limit_value_provided?, :offset_value, :job_class_name,
-          :default_page_size, :worker_id, :recurring_task_id, to: :jobs_relation
+          :default_page_size, :worker_id, :recurring_task_id, :finished_at_start, :finished_at_end, to: :jobs_relation
 
         def executions
           execution_class_by_status
@@ -186,6 +186,7 @@ def finished_jobs
           SolidQueue::Job.finished
             .then { |jobs| filter_jobs_by_queue(jobs) }
             .then { |jobs| filter_jobs_by_class(jobs) }
+            .then { |jobs| filter_jobs_by_finished_at(jobs) }
             .then { |jobs| limit(jobs) }
             .then { |jobs| offset(jobs) }
         end
@@ -267,6 +268,18 @@ def filter_jobs_by_class(jobs)
           job_class_name.present? ? jobs.where(class_name: job_class_name) : jobs
         end
 
+        def filter_jobs_by_finished_at(jobs)
+          if finished_at_start.present? && finished_at_end.present?
+            jobs.where('finished_at >= ? AND finished_at <= ?', finished_at_start, finished_at_end)
+          elsif finished_at_start.present?
+            jobs.where('finished_at >= ?', finished_at_start)
+          elsif finished_at_end.present?
+            jobs.where('finished_at <= ?', finished_at_end)
+          else
+            jobs
+          end
+        end
+
         def limit(executions_or_jobs)
           limit_value.present? ? executions_or_jobs.limit(limit_value) : executions_or_jobs
         end

From b4692060ae8d0fb4d479fa9a56ab610513c7455a Mon Sep 17 00:00:00 2001
From: Ezequiel Salas <salaseze@gmail.com>
Date: Fri, 5 Apr 2024 21:56:24 -0300
Subject: [PATCH 03/24] added filters to _filters partial and params

---
 .../concerns/mission_control/jobs/job_filters.rb          | 4 +++-
 app/views/mission_control/jobs/jobs/_filters.html.erb     | 8 ++++++++
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/app/controllers/concerns/mission_control/jobs/job_filters.rb b/app/controllers/concerns/mission_control/jobs/job_filters.rb
index 01a171d4..b14ac159 100644
--- a/app/controllers/concerns/mission_control/jobs/job_filters.rb
+++ b/app/controllers/concerns/mission_control/jobs/job_filters.rb
@@ -9,7 +9,9 @@ module MissionControl::Jobs::JobFilters
 
   private
     def set_filters
-      @job_filters = { job_class_name: params.dig(:filter, :job_class_name).presence, queue_name: params.dig(:filter, :queue_name).presence }.compact
+      @job_filters = { job_class_name: params.dig(:filter, :job_class_name).presence, queue_name: params.dig(:filter, :queue_name).presence,
+                       finished_at_start: params.dig(:filter, :finished_at_start).presence, finished_at_end: params.dig(:filter, :finished_at_end) }.compact
+    end
     end
 
     def active_filters?
diff --git a/app/views/mission_control/jobs/jobs/_filters.html.erb b/app/views/mission_control/jobs/jobs/_filters.html.erb
index 5421762f..8cde0e92 100644
--- a/app/views/mission_control/jobs/jobs/_filters.html.erb
+++ b/app/views/mission_control/jobs/jobs/_filters.html.erb
@@ -12,6 +12,14 @@
           <%= form.text_field :queue_name, value: @job_filters[:queue_name], class: "input", list: "queue-names", placeholder: "Filter by queue name..." %>
         </div>
 
+        <div class="select is-rounded">
+          <%= form.datetime_field :finished_at_start, value: @job_filters[:finished_at_start], class: "input", placeholder: "Finished from" %>
+        </div>
+
+        <div class="select is-rounded">
+          <%= form.datetime_field :finished_at_end, value: @job_filters[:finished_at_end], class: "input", placeholder: "Finished to" %>
+        </div>
+
         <%= hidden_field_tag :server_id, MissionControl::Jobs::Current.server.id %>
 
         <datalist id="job-classes" style="display: none;">

From 2e4291d8f11cc659e56989afab4893506c6052bd Mon Sep 17 00:00:00 2001
From: Ezequiel Salas <salaseze@gmail.com>
Date: Fri, 5 Apr 2024 21:57:10 -0300
Subject: [PATCH 04/24] added timezone

---
 app/controllers/concerns/mission_control/jobs/job_filters.rb | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/app/controllers/concerns/mission_control/jobs/job_filters.rb b/app/controllers/concerns/mission_control/jobs/job_filters.rb
index b14ac159..b9eafdd4 100644
--- a/app/controllers/concerns/mission_control/jobs/job_filters.rb
+++ b/app/controllers/concerns/mission_control/jobs/job_filters.rb
@@ -11,7 +11,12 @@ module MissionControl::Jobs::JobFilters
     def set_filters
       @job_filters = { job_class_name: params.dig(:filter, :job_class_name).presence, queue_name: params.dig(:filter, :queue_name).presence,
                        finished_at_start: params.dig(:filter, :finished_at_start).presence, finished_at_end: params.dig(:filter, :finished_at_end) }.compact
+      finished_at_timezoned_filters
     end
+
+    def finished_at_timezoned_filters
+      @job_filters[:finished_at_start] = DateTime.parse(@job_filters[:finished_at_start]).in_time_zone if @job_filters[:finished_at_start].present?
+      @job_filters[:finished_at_end] = DateTime.parse(@job_filters[:finished_at_end]).in_time_zone if @job_filters[:finished_at_end].present?
     end
 
     def active_filters?

From 5b41d16769671e31739648852dda588bb1541201 Mon Sep 17 00:00:00 2001
From: Ezequiel Salas <salaseze@gmail.com>
Date: Sun, 7 Apr 2024 11:37:33 -0300
Subject: [PATCH 05/24] show finished_at filters if jobs_status is 'finished'

---
 .../mission_control/jobs/jobs/_filters.html.erb  | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/app/views/mission_control/jobs/jobs/_filters.html.erb b/app/views/mission_control/jobs/jobs/_filters.html.erb
index 8cde0e92..9d993241 100644
--- a/app/views/mission_control/jobs/jobs/_filters.html.erb
+++ b/app/views/mission_control/jobs/jobs/_filters.html.erb
@@ -12,13 +12,15 @@
           <%= form.text_field :queue_name, value: @job_filters[:queue_name], class: "input", list: "queue-names", placeholder: "Filter by queue name..." %>
         </div>
 
-        <div class="select is-rounded">
-          <%= form.datetime_field :finished_at_start, value: @job_filters[:finished_at_start], class: "input", placeholder: "Finished from" %>
-        </div>
-
-        <div class="select is-rounded">
-          <%= form.datetime_field :finished_at_end, value: @job_filters[:finished_at_end], class: "input", placeholder: "Finished to" %>
-        </div>
+        <% if jobs_status == 'finished' %>
+          <div class="select is-rounded">
+            <%= form.datetime_field :finished_at_start, value: @job_filters[:finished_at_start], class: "input", placeholder: "Finished from" %>
+          </div>
+
+          <div class="select is-rounded">
+            <%= form.datetime_field :finished_at_end, value: @job_filters[:finished_at_end], class: "input", placeholder: "Finished to" %>
+          </div>
+        <% end %>
 
         <%= hidden_field_tag :server_id, MissionControl::Jobs::Current.server.id %>
 

From 60eec4dc82d083f82e46e1782542201d33c739c3 Mon Sep 17 00:00:00 2001
From: Ezequiel Salas <salaseze@gmail.com>
Date: Tue, 9 Apr 2024 22:08:03 -0300
Subject: [PATCH 06/24] added comments to jobs_relation where method

---
 lib/active_job/jobs_relation.rb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/active_job/jobs_relation.rb b/lib/active_job/jobs_relation.rb
index d773c691..49dd05ed 100644
--- a/lib/active_job/jobs_relation.rb
+++ b/lib/active_job/jobs_relation.rb
@@ -51,6 +51,8 @@ def initialize(queue_adapter: ActiveJob::Base.queue_adapter, default_page_size:
   # * <tt>:queue_name</tt> - To only include the jobs in the provided queue.
   # * <tt>:worker_id</tt> - To only include the jobs processed by the provided worker.
   # * <tt>:recurring_task_id</tt> - To only include the jobs corresponding to runs of a recurring task.
+  # * <tt>:finished_at_start</tt> - To only include the jobs finished after the provided date.
+  # * <tt>:finished_at_end</tt> - To only include the jobs finished before the provided date.
   def where(job_class_name: nil, queue_name: nil, worker_id: nil, recurring_task_id: nil, finished_at_start: nil, finished_at_end: nil)
     # Remove nil arguments to avoid overriding parameters when concatenating +where+ clauses
     arguments = { job_class_name: job_class_name,

From b2c0808fe790a660f05dce2ca16cc24ad5621846 Mon Sep 17 00:00:00 2001
From: Ezequiel Salas <salaseze@gmail.com>
Date: Wed, 10 Apr 2024 16:16:26 -0300
Subject: [PATCH 07/24] clean finished_at_* filter values when clear button
 clicked

---
 app/views/mission_control/jobs/jobs/_filters.html.erb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/views/mission_control/jobs/jobs/_filters.html.erb b/app/views/mission_control/jobs/jobs/_filters.html.erb
index 9d993241..7565a39d 100644
--- a/app/views/mission_control/jobs/jobs/_filters.html.erb
+++ b/app/views/mission_control/jobs/jobs/_filters.html.erb
@@ -39,7 +39,7 @@
     </div>
 
     <div class="control">
-      <%= link_to "Clear", application_jobs_path(MissionControl::Jobs::Current.application, jobs_status, job_class_name: nil, queue_name: nil), class: "button" %>
+      <%= link_to "Clear", application_jobs_path(MissionControl::Jobs::Current.application, jobs_status, job_class_name: nil, queue_name: nil, finished_at_start: nil, finished_at_end: nil), class: "button" %>
     </div>
   </div>
 </div>

From f0753a910388f02a60ab2ccf8c72d0055b721dca Mon Sep 17 00:00:00 2001
From: Ezequiel Salas <salaseze@gmail.com>
Date: Wed, 10 Apr 2024 16:18:30 -0300
Subject: [PATCH 08/24] double instead of single quoted strings (rubocop)

---
 lib/active_job/queue_adapters/solid_queue_ext.rb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/active_job/queue_adapters/solid_queue_ext.rb b/lib/active_job/queue_adapters/solid_queue_ext.rb
index b69dc2cd..f9161fdb 100644
--- a/lib/active_job/queue_adapters/solid_queue_ext.rb
+++ b/lib/active_job/queue_adapters/solid_queue_ext.rb
@@ -270,11 +270,11 @@ def filter_jobs_by_class(jobs)
 
         def filter_jobs_by_finished_at(jobs)
           if finished_at_start.present? && finished_at_end.present?
-            jobs.where('finished_at >= ? AND finished_at <= ?', finished_at_start, finished_at_end)
+            jobs.where("finished_at >= ? AND finished_at <= ?", finished_at_start, finished_at_end)
           elsif finished_at_start.present?
-            jobs.where('finished_at >= ?', finished_at_start)
+            jobs.where("finished_at >= ?", finished_at_start)
           elsif finished_at_end.present?
-            jobs.where('finished_at <= ?', finished_at_end)
+            jobs.where("finished_at <= ?", finished_at_end)
           else
             jobs
           end

From 62d5b3b24bc77bf358dd64d374f17f47b859c416 Mon Sep 17 00:00:00 2001
From: Ezequiel Salas <salaseze@gmail.com>
Date: Mon, 10 Jun 2024 09:05:31 -0300
Subject: [PATCH 09/24] enhacements set filters

---
 .../concerns/mission_control/jobs/job_filters.rb    | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/app/controllers/concerns/mission_control/jobs/job_filters.rb b/app/controllers/concerns/mission_control/jobs/job_filters.rb
index b9eafdd4..cf56c6d2 100644
--- a/app/controllers/concerns/mission_control/jobs/job_filters.rb
+++ b/app/controllers/concerns/mission_control/jobs/job_filters.rb
@@ -10,16 +10,15 @@ module MissionControl::Jobs::JobFilters
   private
     def set_filters
       @job_filters = { job_class_name: params.dig(:filter, :job_class_name).presence, queue_name: params.dig(:filter, :queue_name).presence,
-                       finished_at_start: params.dig(:filter, :finished_at_start).presence, finished_at_end: params.dig(:filter, :finished_at_end) }.compact
-      finished_at_timezoned_filters
-    end
-
-    def finished_at_timezoned_filters
-      @job_filters[:finished_at_start] = DateTime.parse(@job_filters[:finished_at_start]).in_time_zone if @job_filters[:finished_at_start].present?
-      @job_filters[:finished_at_end] = DateTime.parse(@job_filters[:finished_at_end]).in_time_zone if @job_filters[:finished_at_end].present?
+                       finished_at_start: date_with_time_zone(params.dig(:filter, :finished_at_start).presence), finished_at_end: date_with_time_zone(params.dig(:filter, :finished_at_end).presence) }.compact
     end
 
     def active_filters?
       @job_filters.any?
     end
+
+    def date_with_time_zone(date)
+      return date if date.nil?
+      DateTime.parse(date).in_time_zone
+    end
 end

From a8073e71f9db1eacdce35f46199d9d5a70923dd1 Mon Sep 17 00:00:00 2001
From: Ezequiel Salas <salaseze@gmail.com>
Date: Sun, 17 Nov 2024 13:31:25 -0300
Subject: [PATCH 10/24] finished_at range enhacement

---
 .../concerns/mission_control/jobs/job_filters.rb    |  2 +-
 .../mission_control/jobs/jobs/_filters.html.erb     |  6 +++---
 lib/active_job/jobs_relation.rb                     | 13 ++++++-------
 lib/active_job/queue_adapters/solid_queue_ext.rb    | 12 ++----------
 4 files changed, 12 insertions(+), 21 deletions(-)

diff --git a/app/controllers/concerns/mission_control/jobs/job_filters.rb b/app/controllers/concerns/mission_control/jobs/job_filters.rb
index cf56c6d2..e7beef4d 100644
--- a/app/controllers/concerns/mission_control/jobs/job_filters.rb
+++ b/app/controllers/concerns/mission_control/jobs/job_filters.rb
@@ -10,7 +10,7 @@ module MissionControl::Jobs::JobFilters
   private
     def set_filters
       @job_filters = { job_class_name: params.dig(:filter, :job_class_name).presence, queue_name: params.dig(:filter, :queue_name).presence,
-                       finished_at_start: date_with_time_zone(params.dig(:filter, :finished_at_start).presence), finished_at_end: date_with_time_zone(params.dig(:filter, :finished_at_end).presence) }.compact
+                       finished_at: date_with_time_zone(params.dig(:filter, :finished_at_start).presence)..date_with_time_zone(params.dig(:filter, :finished_at_end).presence) }.compact
     end
 
     def active_filters?
diff --git a/app/views/mission_control/jobs/jobs/_filters.html.erb b/app/views/mission_control/jobs/jobs/_filters.html.erb
index 6564cb1b..50bba3fd 100644
--- a/app/views/mission_control/jobs/jobs/_filters.html.erb
+++ b/app/views/mission_control/jobs/jobs/_filters.html.erb
@@ -14,11 +14,11 @@
 
         <% if jobs_status == 'finished' %>
           <div class="select is-rounded">
-            <%= form.datetime_field :finished_at_start, value: @job_filters[:finished_at_start], class: "input", placeholder: "Finished from" %>
+            <%= form.datetime_field :finished_at_start, value: params.dig(:filter, :finished_at_start), class: "input", placeholder: "Finished from" %>
           </div>
 
           <div class="select is-rounded">
-            <%= form.datetime_field :finished_at_end, value: @job_filters[:finished_at_end], class: "input", placeholder: "Finished to" %>
+            <%= form.datetime_field :finished_at_end, value: params.dig(:filter, :finished_at_end), class: "input", placeholder: "Finished to" %>
           </div>
         <% end %>
 
@@ -39,7 +39,7 @@
     </div>
 
     <div class="control">
-      <%= link_to "Clear", application_jobs_path(MissionControl::Jobs::Current.application, jobs_status, job_class_name: nil, queue_name: nil, finished_at_start: nil, finished_at_end: nil), class: "button" %>
+      <%= link_to "Clear", application_jobs_path(MissionControl::Jobs::Current.application, jobs_status, job_class_name: nil, queue_name: nil, finished_at: nil..nil), class: "button" %>
     </div>
   </div>
 </div>
diff --git a/lib/active_job/jobs_relation.rb b/lib/active_job/jobs_relation.rb
index 6bd94c50..16dfa278 100644
--- a/lib/active_job/jobs_relation.rb
+++ b/lib/active_job/jobs_relation.rb
@@ -23,9 +23,9 @@ class ActiveJob::JobsRelation
   include Enumerable
 
   STATUSES = %i[ pending failed in_progress blocked scheduled finished ]
-  FILTERS = %i[ queue_name job_class_name finished_at_start finished_at_end ]
+  FILTERS = %i[ queue_name job_class_name finished_at ]
 
-  PROPERTIES = %i[ queue_name status offset_value limit_value job_class_name worker_id recurring_task_id finished_at_start finished_at_end ]
+  PROPERTIES = %i[ queue_name status offset_value limit_value job_class_name worker_id recurring_task_id finished_at ]
   attr_reader *PROPERTIES, :default_page_size
 
   delegate :last, :[], :reverse, to: :to_a
@@ -51,18 +51,17 @@ def initialize(queue_adapter: ActiveJob::Base.queue_adapter, default_page_size:
   # * <tt>:queue_name</tt> - To only include the jobs in the provided queue.
   # * <tt>:worker_id</tt> - To only include the jobs processed by the provided worker.
   # * <tt>:recurring_task_id</tt> - To only include the jobs corresponding to runs of a recurring task.
-  # * <tt>:finished_at_start</tt> - To only include the jobs finished after the provided date.
-  # * <tt>:finished_at_end</tt> - To only include the jobs finished before the provided date.
-  def where(job_class_name: nil, queue_name: nil, worker_id: nil, recurring_task_id: nil, finished_at_start: nil, finished_at_end: nil)
+  # * <tt>:finished_at</tt> - (Range) To only include the jobs finished between de provided range
+  def where(job_class_name: nil, queue_name: nil, worker_id: nil, recurring_task_id: nil, finished_at: nil)
     # Remove nil arguments to avoid overriding parameters when concatenating +where+ clauses
     arguments = { job_class_name: job_class_name,
       queue_name: queue_name,
       worker_id: worker_id,
       recurring_task_id: recurring_task_id,
-      finished_at_start: finished_at_start,
-      finished_at_end: finished_at_end
     }.compact.collect { |key, value| [ key, value.to_s ] }.to_h
 
+    arguments.merge!(finished_at: finished_at) if finished_at.present? && !finished_at.to_s.match?(/^..$/)
+
     clone_with **arguments
   end
 
diff --git a/lib/active_job/queue_adapters/solid_queue_ext.rb b/lib/active_job/queue_adapters/solid_queue_ext.rb
index 012403d9..2db9ea14 100644
--- a/lib/active_job/queue_adapters/solid_queue_ext.rb
+++ b/lib/active_job/queue_adapters/solid_queue_ext.rb
@@ -173,7 +173,7 @@ def retry_all
         attr_reader :jobs_relation
 
         delegate :queue_name, :limit_value, :limit_value_provided?, :offset_value, :job_class_name,
-          :default_page_size, :worker_id, :recurring_task_id, :finished_at_start, :finished_at_end, to: :jobs_relation
+          :default_page_size, :worker_id, :recurring_task_id, :finished_at, to: :jobs_relation
 
         def executions
           execution_class_by_status
@@ -273,15 +273,7 @@ def filter_jobs_by_class(jobs)
         end
 
         def filter_jobs_by_finished_at(jobs)
-          if finished_at_start.present? && finished_at_end.present?
-            jobs.where("finished_at >= ? AND finished_at <= ?", finished_at_start, finished_at_end)
-          elsif finished_at_start.present?
-            jobs.where("finished_at >= ?", finished_at_start)
-          elsif finished_at_end.present?
-            jobs.where("finished_at <= ?", finished_at_end)
-          else
-            jobs
-          end
+          finished_at.present? ? jobs.where(finished_at: finished_at) : jobs
         end
 
         def limit(executions_or_jobs)

From 35251691347006643482108bbc0f629b281bd7d3 Mon Sep 17 00:00:00 2001
From: Ezequiel Salas <salaseze@gmail.com>
Date: Sun, 17 Nov 2024 16:57:36 -0300
Subject: [PATCH 11/24] enhace date_with_time_zone method

Co-authored-by: Rosa Gutierrez <rosa.ge@gmail.com>
---
 app/controllers/concerns/mission_control/jobs/job_filters.rb | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/app/controllers/concerns/mission_control/jobs/job_filters.rb b/app/controllers/concerns/mission_control/jobs/job_filters.rb
index e7beef4d..ce610ca9 100644
--- a/app/controllers/concerns/mission_control/jobs/job_filters.rb
+++ b/app/controllers/concerns/mission_control/jobs/job_filters.rb
@@ -18,7 +18,8 @@ def active_filters?
     end
 
     def date_with_time_zone(date)
-      return date if date.nil?
-      DateTime.parse(date).in_time_zone
+      if date.present?
+        DateTime.parse(date).in_time_zone
+      end
     end
 end

From 550340212658c87ef1ed31552d78f31fe006c8c5 Mon Sep 17 00:00:00 2001
From: Ezequiel Salas <salaseze@gmail.com>
Date: Sun, 17 Nov 2024 16:56:47 -0300
Subject: [PATCH 12/24] back to @job_filters in _filters

---
 app/views/mission_control/jobs/jobs/_filters.html.erb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/views/mission_control/jobs/jobs/_filters.html.erb b/app/views/mission_control/jobs/jobs/_filters.html.erb
index 50bba3fd..8333a82e 100644
--- a/app/views/mission_control/jobs/jobs/_filters.html.erb
+++ b/app/views/mission_control/jobs/jobs/_filters.html.erb
@@ -14,11 +14,11 @@
 
         <% if jobs_status == 'finished' %>
           <div class="select is-rounded">
-            <%= form.datetime_field :finished_at_start, value: params.dig(:filter, :finished_at_start), class: "input", placeholder: "Finished from" %>
+            <%= form.datetime_field :finished_at_start, value: @job_filters[:finished_at].begin, class: "input", placeholder: "Finished from" %>
           </div>
 
           <div class="select is-rounded">
-            <%= form.datetime_field :finished_at_end, value: params.dig(:filter, :finished_at_end), class: "input", placeholder: "Finished to" %>
+            <%= form.datetime_field :finished_at_end, value: @job_filters[:finished_at].end, class: "input", placeholder: "Finished to" %>
           </div>
         <% end %>
 

From 38b3bf355f763f055767773cacf015f11fd342da Mon Sep 17 00:00:00 2001
From: Ezequiel Salas <salaseze@gmail.com>
Date: Sun, 17 Nov 2024 16:58:38 -0300
Subject: [PATCH 13/24] god bye presence

---
 app/controllers/concerns/mission_control/jobs/job_filters.rb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/app/controllers/concerns/mission_control/jobs/job_filters.rb b/app/controllers/concerns/mission_control/jobs/job_filters.rb
index ce610ca9..84a22255 100644
--- a/app/controllers/concerns/mission_control/jobs/job_filters.rb
+++ b/app/controllers/concerns/mission_control/jobs/job_filters.rb
@@ -10,13 +10,14 @@ module MissionControl::Jobs::JobFilters
   private
     def set_filters
       @job_filters = { job_class_name: params.dig(:filter, :job_class_name).presence, queue_name: params.dig(:filter, :queue_name).presence,
-                       finished_at: date_with_time_zone(params.dig(:filter, :finished_at_start).presence)..date_with_time_zone(params.dig(:filter, :finished_at_end).presence) }.compact
+                       finished_at: date_with_time_zone(params.dig(:filter, :finished_at_start))..date_with_time_zone(params.dig(:filter, :finished_at_end)) }.compact
     end
 
     def active_filters?
       @job_filters.any?
     end
 
+    # TODO: move to helpers ?
     def date_with_time_zone(date)
       if date.present?
         DateTime.parse(date).in_time_zone

From 25142b7e27870222b1c562b209c6e9488a720816 Mon Sep 17 00:00:00 2001
From: Ezequiel Salas <salaseze@gmail.com>
Date: Sun, 17 Nov 2024 19:07:30 -0300
Subject: [PATCH 14/24] bye collect arguments with to_s for values

---
 lib/active_job/jobs_relation.rb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/active_job/jobs_relation.rb b/lib/active_job/jobs_relation.rb
index 16dfa278..e4e19ee0 100644
--- a/lib/active_job/jobs_relation.rb
+++ b/lib/active_job/jobs_relation.rb
@@ -58,9 +58,8 @@ def where(job_class_name: nil, queue_name: nil, worker_id: nil, recurring_task_i
       queue_name: queue_name,
       worker_id: worker_id,
       recurring_task_id: recurring_task_id,
-    }.compact.collect { |key, value| [ key, value.to_s ] }.to_h
-
-    arguments.merge!(finished_at: finished_at) if finished_at.present? && !finished_at.to_s.match?(/^..$/)
+      finished_at: finished_at
+    }.compact
 
     clone_with **arguments
   end
@@ -277,6 +276,7 @@ def satisfy_filter?(job)
     end
 
     def filters
+      # @filetrs ||= queue_adapter.supported_job_filters(self).select { |property| public_send(property).present? && !queue_adapter.natively_supported_job_filters?(self, property) }
       @filters ||= FILTERS.select { |property| public_send(property).present? && !queue_adapter.supports_job_filter?(self, property) }
     end
 

From 9d95d16d57e960fe2a721bf5927a0f4af994c707 Mon Sep 17 00:00:00 2001
From: Ezequiel Salas <salaseze@gmail.com>
Date: Sun, 17 Nov 2024 19:07:43 -0300
Subject: [PATCH 15/24] fix tests

---
 test/active_job/queue_adapters/adapter_testing/count_jobs.rb   | 2 +-
 test/active_job/queue_adapters/adapter_testing/discard_jobs.rb | 2 +-
 test/active_job/queue_adapters/adapter_testing/query_jobs.rb   | 2 +-
 test/active_job/queue_adapters/adapter_testing/retry_jobs.rb   | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/test/active_job/queue_adapters/adapter_testing/count_jobs.rb b/test/active_job/queue_adapters/adapter_testing/count_jobs.rb
index ebc8a55d..7cecce0f 100644
--- a/test/active_job/queue_adapters/adapter_testing/count_jobs.rb
+++ b/test/active_job/queue_adapters/adapter_testing/count_jobs.rb
@@ -35,7 +35,7 @@ module ActiveJob::QueueAdapters::AdapterTesting::CountJobs
     assert_equal 8, ActiveJob.queues.sum(&:size)
     assert_equal 5, ActiveJob.jobs.pending.where(queue_name: "default").count
     assert_equal 3, ActiveJob.jobs.pending.where(queue_name: "other_queue").count
-    assert_equal 3, ActiveJob.jobs.pending.where(queue_name: :other_queue).count
+    assert_equal 3, ActiveJob.jobs.pending.where(queue_name: "other_queue").count
 
     assert_equal 5, ActiveJob.queues[:default].size
     assert_equal 3, ActiveJob.queues[:other_queue].size
diff --git a/test/active_job/queue_adapters/adapter_testing/discard_jobs.rb b/test/active_job/queue_adapters/adapter_testing/discard_jobs.rb
index 98d7c9bd..0ee0d467 100644
--- a/test/active_job/queue_adapters/adapter_testing/discard_jobs.rb
+++ b/test/active_job/queue_adapters/adapter_testing/discard_jobs.rb
@@ -60,7 +60,7 @@ module ActiveJob::QueueAdapters::AdapterTesting::DiscardJobs
     5.times { FailingJob.perform_later }
     10.times { FailingReloadedJob.perform_later }
     perform_enqueued_jobs
-    ActiveJob.jobs.failed.where(queue_name: :queue_1).discard_all
+    ActiveJob.jobs.failed.where(queue_name: 'queue_1').discard_all
 
     assert_empty ActiveJob.jobs.failed.where(job_class_name: "FailingJob")
     assert_equal 10, ActiveJob.jobs.failed.where(job_class_name: "FailingReloadedJob").count
diff --git a/test/active_job/queue_adapters/adapter_testing/query_jobs.rb b/test/active_job/queue_adapters/adapter_testing/query_jobs.rb
index f870e9d8..723f0ddf 100644
--- a/test/active_job/queue_adapters/adapter_testing/query_jobs.rb
+++ b/test/active_job/queue_adapters/adapter_testing/query_jobs.rb
@@ -112,7 +112,7 @@ module ActiveJob::QueueAdapters::AdapterTesting::QueryJobs
     10.times { |index| WithPaginationDummyJob.perform_later(index) }
     4.times { |index| WithPaginationFailingJob.perform_later(index) }
 
-    jobs = ActiveJob.jobs.pending.where(queue_name: :default, job_class_name: WithPaginationDummyJob).to_a
+    jobs = ActiveJob.jobs.pending.where(queue_name: :default, job_class_name: 'WithPaginationDummyJob').to_a
     assert_equal 10, jobs.size
   end
 
diff --git a/test/active_job/queue_adapters/adapter_testing/retry_jobs.rb b/test/active_job/queue_adapters/adapter_testing/retry_jobs.rb
index 9bc91c3e..297bfcea 100644
--- a/test/active_job/queue_adapters/adapter_testing/retry_jobs.rb
+++ b/test/active_job/queue_adapters/adapter_testing/retry_jobs.rb
@@ -79,7 +79,7 @@ module ActiveJob::QueueAdapters::AdapterTesting::RetryJobs
 
     assert_equal 15, ActiveJob.jobs.failed.count
 
-    failed_jobs = ActiveJob.jobs.failed.where(queue_name: :queue_2)
+    failed_jobs = ActiveJob.jobs.failed.where(queue_name: 'queue_2')
     failed_jobs.retry_all
 
     assert_equal 10, ActiveJob.jobs.failed.count

From 4d7cb3e6d6949146c16ad8766527f3e1a6c3d225 Mon Sep 17 00:00:00 2001
From: Ezequiel Salas <salaseze@gmail.com>
Date: Sun, 24 Nov 2024 13:37:03 -0300
Subject: [PATCH 16/24] bringed back .to_s for queue_name parameters
 (JobsRelation#where)

---
 lib/active_job/jobs_relation.rb                                | 2 +-
 test/active_job/queue_adapters/adapter_testing/discard_jobs.rb | 2 +-
 test/active_job/queue_adapters/adapter_testing/retry_jobs.rb   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/active_job/jobs_relation.rb b/lib/active_job/jobs_relation.rb
index e4e19ee0..9ef7d93e 100644
--- a/lib/active_job/jobs_relation.rb
+++ b/lib/active_job/jobs_relation.rb
@@ -55,7 +55,7 @@ def initialize(queue_adapter: ActiveJob::Base.queue_adapter, default_page_size:
   def where(job_class_name: nil, queue_name: nil, worker_id: nil, recurring_task_id: nil, finished_at: nil)
     # Remove nil arguments to avoid overriding parameters when concatenating +where+ clauses
     arguments = { job_class_name: job_class_name,
-      queue_name: queue_name,
+      queue_name: queue_name&.to_s,
       worker_id: worker_id,
       recurring_task_id: recurring_task_id,
       finished_at: finished_at
diff --git a/test/active_job/queue_adapters/adapter_testing/discard_jobs.rb b/test/active_job/queue_adapters/adapter_testing/discard_jobs.rb
index 0ee0d467..98d7c9bd 100644
--- a/test/active_job/queue_adapters/adapter_testing/discard_jobs.rb
+++ b/test/active_job/queue_adapters/adapter_testing/discard_jobs.rb
@@ -60,7 +60,7 @@ module ActiveJob::QueueAdapters::AdapterTesting::DiscardJobs
     5.times { FailingJob.perform_later }
     10.times { FailingReloadedJob.perform_later }
     perform_enqueued_jobs
-    ActiveJob.jobs.failed.where(queue_name: 'queue_1').discard_all
+    ActiveJob.jobs.failed.where(queue_name: :queue_1).discard_all
 
     assert_empty ActiveJob.jobs.failed.where(job_class_name: "FailingJob")
     assert_equal 10, ActiveJob.jobs.failed.where(job_class_name: "FailingReloadedJob").count
diff --git a/test/active_job/queue_adapters/adapter_testing/retry_jobs.rb b/test/active_job/queue_adapters/adapter_testing/retry_jobs.rb
index 297bfcea..9bc91c3e 100644
--- a/test/active_job/queue_adapters/adapter_testing/retry_jobs.rb
+++ b/test/active_job/queue_adapters/adapter_testing/retry_jobs.rb
@@ -79,7 +79,7 @@ module ActiveJob::QueueAdapters::AdapterTesting::RetryJobs
 
     assert_equal 15, ActiveJob.jobs.failed.count
 
-    failed_jobs = ActiveJob.jobs.failed.where(queue_name: 'queue_2')
+    failed_jobs = ActiveJob.jobs.failed.where(queue_name: :queue_2)
     failed_jobs.retry_all
 
     assert_equal 10, ActiveJob.jobs.failed.count

From 02547a2cdb66ef5980e6c07c5802fd63049bf79c Mon Sep 17 00:00:00 2001
From: Ezequiel Salas <salaseze@gmail.com>
Date: Mon, 25 Nov 2024 18:24:59 -0300
Subject: [PATCH 17/24] queue_name back to symbol

---
 test/active_job/queue_adapters/adapter_testing/count_jobs.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/active_job/queue_adapters/adapter_testing/count_jobs.rb b/test/active_job/queue_adapters/adapter_testing/count_jobs.rb
index 7cecce0f..ebc8a55d 100644
--- a/test/active_job/queue_adapters/adapter_testing/count_jobs.rb
+++ b/test/active_job/queue_adapters/adapter_testing/count_jobs.rb
@@ -35,7 +35,7 @@ module ActiveJob::QueueAdapters::AdapterTesting::CountJobs
     assert_equal 8, ActiveJob.queues.sum(&:size)
     assert_equal 5, ActiveJob.jobs.pending.where(queue_name: "default").count
     assert_equal 3, ActiveJob.jobs.pending.where(queue_name: "other_queue").count
-    assert_equal 3, ActiveJob.jobs.pending.where(queue_name: "other_queue").count
+    assert_equal 3, ActiveJob.jobs.pending.where(queue_name: :other_queue).count
 
     assert_equal 5, ActiveJob.queues[:default].size
     assert_equal 3, ActiveJob.queues[:other_queue].size

From 2d17d1e9cd44f9ad58c8ee95d920376f53d78e29 Mon Sep 17 00:00:00 2001
From: Ezequiel Salas <salaseze@gmail.com>
Date: Mon, 25 Nov 2024 18:29:12 -0300
Subject: [PATCH 18/24] bye finished_at from FILTERS

---
 lib/active_job/jobs_relation.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/active_job/jobs_relation.rb b/lib/active_job/jobs_relation.rb
index 9ef7d93e..edad0332 100644
--- a/lib/active_job/jobs_relation.rb
+++ b/lib/active_job/jobs_relation.rb
@@ -23,7 +23,7 @@ class ActiveJob::JobsRelation
   include Enumerable
 
   STATUSES = %i[ pending failed in_progress blocked scheduled finished ]
-  FILTERS = %i[ queue_name job_class_name finished_at ]
+  FILTERS = %i[ queue_name job_class_name ]
 
   PROPERTIES = %i[ queue_name status offset_value limit_value job_class_name worker_id recurring_task_id finished_at ]
   attr_reader *PROPERTIES, :default_page_size

From 4295a3dcbd06894c8d83682def2ffafd8e6b01ca Mon Sep 17 00:00:00 2001
From: Ezequiel Salas <salaseze@gmail.com>
Date: Mon, 25 Nov 2024 18:29:37 -0300
Subject: [PATCH 19/24] bye comment

---
 lib/active_job/jobs_relation.rb | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/active_job/jobs_relation.rb b/lib/active_job/jobs_relation.rb
index edad0332..08007d4f 100644
--- a/lib/active_job/jobs_relation.rb
+++ b/lib/active_job/jobs_relation.rb
@@ -276,7 +276,6 @@ def satisfy_filter?(job)
     end
 
     def filters
-      # @filetrs ||= queue_adapter.supported_job_filters(self).select { |property| public_send(property).present? && !queue_adapter.natively_supported_job_filters?(self, property) }
       @filters ||= FILTERS.select { |property| public_send(property).present? && !queue_adapter.supports_job_filter?(self, property) }
     end
 

From 0b07af3b45767601301c825699e16a3f13957f4d Mon Sep 17 00:00:00 2001
From: Ezequiel Salas <salaseze@gmail.com>
Date: Mon, 25 Nov 2024 18:30:01 -0300
Subject: [PATCH 20/24] added finished_at in supported_job_filters (SolidQueue)

---
 lib/active_job/queue_adapters/solid_queue_ext.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/active_job/queue_adapters/solid_queue_ext.rb b/lib/active_job/queue_adapters/solid_queue_ext.rb
index 2db9ea14..ab9b876f 100644
--- a/lib/active_job/queue_adapters/solid_queue_ext.rb
+++ b/lib/active_job/queue_adapters/solid_queue_ext.rb
@@ -40,7 +40,7 @@ def supported_job_statuses
   end
 
   def supported_job_filters(*)
-    [ :queue_name, :job_class_name, :finished_at_start, :finished_at_end ]
+    [ :queue_name, :job_class_name, :finished_at ]
   end
 
   def jobs_count(jobs_relation)

From a82d2d85992d18831f48d0d31ee5e1f33e50fc0c Mon Sep 17 00:00:00 2001
From: Ezequiel Salas <salaseze@gmail.com>
Date: Tue, 26 Nov 2024 10:41:58 -0300
Subject: [PATCH 21/24] Update
 app/views/mission_control/jobs/jobs/_filters.html.erb

Co-authored-by: Rosa Gutierrez <rosa.ge@gmail.com>
---
 app/views/mission_control/jobs/jobs/_filters.html.erb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/views/mission_control/jobs/jobs/_filters.html.erb b/app/views/mission_control/jobs/jobs/_filters.html.erb
index 8333a82e..9a788b99 100644
--- a/app/views/mission_control/jobs/jobs/_filters.html.erb
+++ b/app/views/mission_control/jobs/jobs/_filters.html.erb
@@ -12,7 +12,7 @@
           <%= form.text_field :queue_name, value: @job_filters[:queue_name], class: "input", list: "queue-names", placeholder: "Filter by queue name..." %>
         </div>
 
-        <% if jobs_status == 'finished' %>
+        <% if jobs_status == "finished" %>
           <div class="select is-rounded">
             <%= form.datetime_field :finished_at_start, value: @job_filters[:finished_at].begin, class: "input", placeholder: "Finished from" %>
           </div>

From 7b10cf46f6747c386451b2ab192fe0bda4a34dec Mon Sep 17 00:00:00 2001
From: Ezequiel Salas <salaseze@gmail.com>
Date: Tue, 26 Nov 2024 10:42:21 -0300
Subject: [PATCH 22/24] Update lib/active_job/jobs_relation.rb

Co-authored-by: Rosa Gutierrez <rosa.ge@gmail.com>
---
 lib/active_job/jobs_relation.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/active_job/jobs_relation.rb b/lib/active_job/jobs_relation.rb
index 08007d4f..0d71e5e4 100644
--- a/lib/active_job/jobs_relation.rb
+++ b/lib/active_job/jobs_relation.rb
@@ -51,7 +51,7 @@ def initialize(queue_adapter: ActiveJob::Base.queue_adapter, default_page_size:
   # * <tt>:queue_name</tt> - To only include the jobs in the provided queue.
   # * <tt>:worker_id</tt> - To only include the jobs processed by the provided worker.
   # * <tt>:recurring_task_id</tt> - To only include the jobs corresponding to runs of a recurring task.
-  # * <tt>:finished_at</tt> - (Range) To only include the jobs finished between de provided range
+  # * <tt>:finished_at</tt> - (Range) To only include the jobs finished between the provided range
   def where(job_class_name: nil, queue_name: nil, worker_id: nil, recurring_task_id: nil, finished_at: nil)
     # Remove nil arguments to avoid overriding parameters when concatenating +where+ clauses
     arguments = { job_class_name: job_class_name,

From ae91239d5f4e171fc3f08183ba897756ea614db7 Mon Sep 17 00:00:00 2001
From: Ezequiel Salas <salaseze@gmail.com>
Date: Wed, 27 Nov 2024 17:27:52 -0300
Subject: [PATCH 23/24] finished_at_range_params method

---
 .../concerns/mission_control/jobs/job_filters.rb       | 10 ++++++++--
 app/views/mission_control/jobs/jobs/_filters.html.erb  |  4 ++--
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/app/controllers/concerns/mission_control/jobs/job_filters.rb b/app/controllers/concerns/mission_control/jobs/job_filters.rb
index 84a22255..7e3b772d 100644
--- a/app/controllers/concerns/mission_control/jobs/job_filters.rb
+++ b/app/controllers/concerns/mission_control/jobs/job_filters.rb
@@ -10,14 +10,20 @@ module MissionControl::Jobs::JobFilters
   private
     def set_filters
       @job_filters = { job_class_name: params.dig(:filter, :job_class_name).presence, queue_name: params.dig(:filter, :queue_name).presence,
-                       finished_at: date_with_time_zone(params.dig(:filter, :finished_at_start))..date_with_time_zone(params.dig(:filter, :finished_at_end)) }.compact
+                       finished_at: finished_at_range_params }.compact
     end
 
     def active_filters?
       @job_filters.any?
     end
 
-    # TODO: move to helpers ?
+    def finished_at_range_params
+      range_start, range_end = params.dig(:filter, :finished_at_start), params.dig(:filter, :finished_at_end)
+      if range_start || range_end
+        (parse_with_time_zone(range_start)..parse_with_time_zone(range_end))
+      end
+    end
+
     def date_with_time_zone(date)
       if date.present?
         DateTime.parse(date).in_time_zone
diff --git a/app/views/mission_control/jobs/jobs/_filters.html.erb b/app/views/mission_control/jobs/jobs/_filters.html.erb
index 9a788b99..89d9b211 100644
--- a/app/views/mission_control/jobs/jobs/_filters.html.erb
+++ b/app/views/mission_control/jobs/jobs/_filters.html.erb
@@ -14,11 +14,11 @@
 
         <% if jobs_status == "finished" %>
           <div class="select is-rounded">
-            <%= form.datetime_field :finished_at_start, value: @job_filters[:finished_at].begin, class: "input", placeholder: "Finished from" %>
+            <%= form.datetime_field :finished_at_start, value: @job_filters[:finished_at]&.begin, class: "input", placeholder: "Finished from" %>
           </div>
 
           <div class="select is-rounded">
-            <%= form.datetime_field :finished_at_end, value: @job_filters[:finished_at].end, class: "input", placeholder: "Finished to" %>
+            <%= form.datetime_field :finished_at_end, value: @job_filters[:finished_at]&.end, class: "input", placeholder: "Finished to" %>
           </div>
         <% end %>
 

From e0bcd9828278e4f508b381d1472108e2036b63b3 Mon Sep 17 00:00:00 2001
From: Ezequiel Salas <salaseze@gmail.com>
Date: Wed, 27 Nov 2024 17:33:55 -0300
Subject: [PATCH 24/24] double quotes

---
 test/active_job/queue_adapters/adapter_testing/query_jobs.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/active_job/queue_adapters/adapter_testing/query_jobs.rb b/test/active_job/queue_adapters/adapter_testing/query_jobs.rb
index 723f0ddf..25a3df1a 100644
--- a/test/active_job/queue_adapters/adapter_testing/query_jobs.rb
+++ b/test/active_job/queue_adapters/adapter_testing/query_jobs.rb
@@ -112,7 +112,7 @@ module ActiveJob::QueueAdapters::AdapterTesting::QueryJobs
     10.times { |index| WithPaginationDummyJob.perform_later(index) }
     4.times { |index| WithPaginationFailingJob.perform_later(index) }
 
-    jobs = ActiveJob.jobs.pending.where(queue_name: :default, job_class_name: 'WithPaginationDummyJob').to_a
+    jobs = ActiveJob.jobs.pending.where(queue_name: :default, job_class_name: "WithPaginationDummyJob").to_a
     assert_equal 10, jobs.size
   end