Rewrite the project in Rust #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make easier for us to change the implmentation later.
ianks
reviewed
Mar 6, 2024
blakfeld
reviewed
Mar 6, 2024
nickpresta
reviewed
Mar 7, 2024
nickpresta
reviewed
Mar 7, 2024
nickpresta
reviewed
Mar 7, 2024
robinbrandt
reviewed
Mar 8, 2024
We only need the binary form.
…optional. This is because the default values are already set in the struct definition.
Avoid deadlock when the child process writes to stdout and fills the buffer. See rust-lang/rust@ce2d95c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to build binaries to each platform so users don't need to install and configure shells.
This is a basic rewrite of the bash script in Rust. Later I'll work in changing the communication to use the Docker API instead of requiring the Docker client to be installed.